Description of problem: After downloading an iso with the same name as a previous one, the browser often saves the file with a space and brackets in the new filename, eg. "/home/cxm/Downloads/Fedora-15-Beta-i686-Live-Desktop (1).iso" This foxes livecd-iso-to-disk: /usr/bin/livecd-iso-to-disk: line 576: [: /home/cxm/Downloads/Fedora-15-Beta-i686-Live-Desktop: binary operator expected /usr/bin/livecd-iso-to-disk: line 578: [: /home/cxm/Downloads/Fedora-15-Beta-i686-Live-Desktop: binary operator expected /home/cxm/Downloads/Fedora-15-Beta-i686-Live-Desktop (1).iso is not a file or block device. Version-Release number of selected component (if applicable): livecd-tools-14.2-1.fc14.i686 How reproducible: 100% Steps to Reproduce: 1. Normal command line with escaped special characters, ie livecd-iso-to-disk /home/cxm/Downloads/Fedora-15-Beta-i686-Live-Desktop\ \(1\).iso /dev/sdb1 Actual results: Errors as above Expected results: Normal operation with filenames even if they are browser mangled Additional info: Browser was Chrome.
(In reply to comment #0) > Description of problem: > After downloading an iso with the same name as a previous one, the browser > often saves the file with a space and brackets in the new filename, eg. ... I used do try to do this too. My workaround is to create separate directories for each of the candidates, which eliminates naming conflicts. $ ls -F fedora/F14/ F14-Alpha/ F14-Beta-RC1/ F14-Beta-RC2/ F14-Beta-RC3/ F14-Final-RC1/
(In reply to comment #1) [...] > My workaround is to create separate directories for each of the candidates, > which eliminates naming conflicts. Renaming the file also works around the problem, although we should probably fix the bug anyway. I didn't realise it was just a bash script, I will attach a patch that attempts to fix the problem.
Created attachment 490882 [details] patch for livecd-iso-to-disk to quote $ISO in case it has unusual characters I tried this with the filename that caused the bug and the disk was written correctly.
Note that this patch doesn't apply against current upstream since most references to $ISO are now $SRC. I am not sure if that change is going to make it to F14 or not. If not I don't see a problem with doing two patches. F14 has enough life left, and the fix is simple enough, that I think its worth doing.
Created attachment 490901 [details] f15 branch version of the patch I have made an f15 branch version of the patch. I didn't check, but likely this would work for the master branch as well.
I looked at master now and the patch probably won't apply cleanly. So I'll look at making one for master as well.
Created attachment 490903 [details] Patch for master branch There is now a patch for master as well. I didn't actually test either of my two patches yet. But I can do some testing and get these applied if I get some agreement for another developer that this is a good way to go.
*** Bug 698070 has been marked as a duplicate of this bug. ***
*** Bug 715262 has been marked as a duplicate of this bug. ***