Bug 695794

+++ This bug was initially created as a clone of Bug #689128 +++

Attached patch fixes typo in code which leads to <cman transport="..." > is ignored if <totem /> XML node is present.

--- Additional comment from bubble on 2011-03-19 13:52:39 EDT ---

Created attachment 486397 [details]
Fix typo

--- Additional comment from fdinitto on 2011-03-22 05:01:22 EDT ---

Hi Vladislav,

in principle the patch is correct, but cannot be applied as is and needs some more work.

<cluster>
 <cman transport="...."/>
 <totem transport="...."/>

In this case the patch should take care to check and either report an error that only one can be specified or eventually apply a bigger hammer and say: cman config has higher priority than totem and take appropriate action.

Basically it needs a failsafe for bad configs.

Thanks
Fabio

--- Additional comment from bubble on 2011-03-22 05:09:14 EDT ---

Will <totem transport="...."/> pass validation?

--- Additional comment from fdinitto on 2011-03-22 05:25:13 EDT ---

(In reply to comment #3)
> Will <totem transport="...."/> pass validation?

even if it doesn´t, validation can always be turned off or set to warning. It´s a matter of trying to be resilient to user errors and make sure expectations are met.

If you specify both, which one should win? etc..

--- Additional comment from bubble on 2011-03-23 09:54:42 EDT ---

Created attachment 487042 [details]
2nd version of patch

Hi Fabio,

attached should be close to what you've requested.

Best,
Vladislav

--- Additional comment from fdinitto on 2011-03-23 10:58:56 EDT ---

(In reply to comment #5)
> Created attachment 487042 [details]
> 2nd version of patch
> 
> Hi Fabio,
> 
> attached should be close to what you've requested.
> 
> Best,
> Vladislav

Hi Vladislav,

at a first glance the patch looks Ok. I'll need to test it before I merge it upstream.

Thanks a lot for your work!

Fabio

--- Additional comment from fdinitto on 2011-03-28 08:12:28 EDT ---

Hi Vladislav,

there is a substantial error in the patch.

transport is a key to totem and not an object underneath totem.

So basically this will never work.

Also your patch triggers the error only when cman and totem transport are specified but it should provide always an error path when specified in totem.