Hide Forgot
Attached patch fixes typo in code which leads to <cman transport="..." > is ignored if <totem /> XML node is present.
Created attachment 486397 [details] Fix typo
Hi Vladislav, in principle the patch is correct, but cannot be applied as is and needs some more work. <cluster> <cman transport="...."/> <totem transport="...."/> In this case the patch should take care to check and either report an error that only one can be specified or eventually apply a bigger hammer and say: cman config has higher priority than totem and take appropriate action. Basically it needs a failsafe for bad configs. Thanks Fabio
Will <totem transport="...."/> pass validation?
(In reply to comment #3) > Will <totem transport="...."/> pass validation? even if it doesn´t, validation can always be turned off or set to warning. It´s a matter of trying to be resilient to user errors and make sure expectations are met. If you specify both, which one should win? etc..
Created attachment 487042 [details] 2nd version of patch Hi Fabio, attached should be close to what you've requested. Best, Vladislav
(In reply to comment #5) > Created attachment 487042 [details] > 2nd version of patch > > Hi Fabio, > > attached should be close to what you've requested. > > Best, > Vladislav Hi Vladislav, at a first glance the patch looks Ok. I'll need to test it before I merge it upstream. Thanks a lot for your work! Fabio
Hi Vladislav, there is a substantial error in the patch. transport is a key to totem and not an object underneath totem. So basically this will never work. Also your patch triggers the error only when cman and totem transport are specified but it should provide always an error path when specified in totem.
This message is a reminder that Fedora 13 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 13. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '13'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 13's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 13 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping
Fedora 13 changed to end-of-life (EOL) status on 2011-06-25. Fedora 13 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed.
http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=da36fb6bc9e7a8908011e41ef78235f6c0160ca6