Bug 696114

Created attachment 491710 [details]
Native systemd service file for radiusd socket

As of freeradius 2.x it has supported configuration check thus I added that to the service file which will check for it upon start/restart and reload and respectfully refuse to re(start) and reload if an error is found. 

To test this copy the attached files to /lib/systemd/system and run 

systemctl daemon-reload

systemctl start/restart/reload/stop/status radiusd.service

Moving systemd service RFEs to rawhide.

At this point, it is not appropriate in the Fedora 15 cycle to add these. Furthermore, at this point, we are still finalizing the packaging guidelines to handle SysV -> systemd upgrades.

We therefore request:
- wait until there are packaging guidelines (this will be announced on the devel list). This ensures that upgrades will work smoothly and we/you won't have to do multiple sets of changes.
- work on these sorts of changes for Fedora 16 where necessary, not Fedora 15, as we're trying to fix things for release.
- do *not* change a service from SysV to systemd in an existing release (such as Fedora 15), as this is the sort of behavior change that goes against our update policy, documented as https://fedoraproject.org/wiki/Updates_Policy

Ping what's the current status of this.. 

https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
http://fedoraproject.org/wiki/Packaging:Tmpfiles.d

re comment #4

I've only done cursory examination of the systemd transition issues. I have not exercised and tested the proposed files (thank you for providing them). At the moment I believe my Redhat manager believes there are higher priority tasks. If this is a time critical issue please advise.

(In reply to comment #5)
> re comment #4
> 
> I've only done cursory examination of the systemd transition issues. I have not
> exercised and tested the proposed files (thank you for providing them). At the
> moment I believe my Redhat manager believes there are higher priority tasks. If
> this is a time critical issue please advise.

It would be good to get this done before alpha ( beginning of august ) as in packaging them to get them into the release and out for testing. 
( I can provide you with a patch against your spec file if needed ) 

Any issue that might crop up can then be fixed during the rest of the release development cycle.

You can test this by simply copy the attached files into /lib/systemd/system directory on F15+ 

then run 

systemctl daemon-reload 

To tell systemd to pickup and use the submitted file then run 

systemctl start/status/stop radiusd.service 

The socket file might be missing that is if it applies.. 

ListenStream=0.0.0.0:1812
ListenStream=[::]:1812
ListenStream=0.0.0.0:1813
ListenStream=[::]:1813

I did not get to test the socket well enough since radius was complaining that he did not own radiusd.sock
( Error: We do not own /var/run/radiusd/radiusd.sock )

Adding 

User=radiusd
Group=radiusd 

To the unit files changed nothing I have absolutely no idea what's going wrong there.

The authentication error might be a upstream bug.. 

http://freeradius.1045715.n5.nabble.com/ownership-change-td2777838.html

Created attachment 511131 [details]
Native systemd service file for raidusd with workaround

Added a workaround for the permission error to the unit file and removed the native radiusd socket file ( dont think we actually need that one ) 

Service now starts cleanly..

# systemctl status radiusd.service
radiusd.service - FreeRADIUS high performance RADIUS server.
	  Loaded: loaded (/lib/systemd/system/radiusd.service)
	  Active: active (running) since Mon, 04 Jul 2011 07:56:10 +0000; 1s ago
	 Process: 31580 ExecStart=/usr/sbin/radiusd -d /etc/raddb (code=exited, status=0/SUCCESS)
	 Process: 31578 ExecStartPre=/usr/sbin/radiusd -C (code=exited, status=0/SUCCESS)
	 Process: 31576 ExecStartPre=/bin/chown -R radiusd.radiusd /var/run/radiusd (code=exited, status=0/SUCCESS)
	Main PID: 31581 (radiusd)
	  CGroup: name=systemd:/system/radiusd.service
		  └ 31581 /usr/sbin/radiusd -d /etc/raddb

# netstat -pan | grep radiusd
udp        0      0 127.0.0.1:18120             0.0.0.0:*                               31581/radiusd       
udp        0      0 0.0.0.0:1812                0.0.0.0:*                               31581/radiusd       
udp        0      0 0.0.0.0:1813                0.0.0.0:*                               31581/radiusd       
udp        0      0 0.0.0.0:1814                0.0.0.0:*                               31581/radiusd       
unix  2      [ ACC ]     STREAM     LISTENING     93628073 31581/radiusd       /var/run/radiusd/radiusd.sock

Created attachment 511138 [details]
freeradius tmpfile

Created attachment 511139 [details]
Patch that Introduce systemd unit file, drop SysV support to the spec file..

freeradius-2.1.11-5.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/freeradius-2.1.11-5.fc16

Package freeradius-2.1.11-5.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing freeradius-2.1.11-5.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/freeradius-2.1.11-5.fc16
then log in and leave karma (feedback).

freeradius-2.1.11-6.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/freeradius-2.1.11-6.fc16

freeradius-2.1.11-7.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/freeradius-2.1.11-7.fc16

freeradius-2.1.11-7.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.