Bug 697612
| Summary: | Providing native systemd file for upcoming F15 Feature Systemd | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jóhann B. Guðmundsson <johannbg> | ||||||
| Component: | smolt | Assignee: | Will Woods <wwoods> | ||||||
| Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | lpoetter, tcallawa, wwoods | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2011-09-08 19:10:15 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 713562 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jóhann B. Guðmundsson
2011-04-18 18:25:25 UTC
The only thing the init script is supposed to do (as far as I can tell) is to create /etc/smolt/hw-uuid if it doesn't exist. The lockfile is useless.
All it really needs to do is:
if [ ! -f /etc/smolt/hw-uuid ]; then
cat /proc/sys/kernel/random/uuid > /etc/smolt/hw-uuid
chmod 0644 /etc/smolt/hw-uuid
chown root.root /etc/smolt/hw-uuid
fi
But I'm not really sure how to make a systemd unit that does that.
The monthly checkin itself is triggered by a cron job.
Created attachment 493326 [details]
New and improved version of smolt systemd service file..
Well technically since this is not an service daemon something else should create this like the application that offers the end user to enable monthly smolt updates but since systemd is so awesome and beefy let's do it.
The service vill refuse to run if /etc/smolt/hw-uuid does exit and once it has run it will disable itself encase something enabled it as a good run once service should do..
I think a nice solution would be to use /etc/machine-id instead of a uuid of its own for identifying the machine. For more details see http://0pointer.de/blog/projects/the-new-configuration-files.html The cron job is triggered by the existence of the /etc/smolt/hw-uuid and the only thing that this so called service does is to create that file. Why this is an sysv init script beats the hell out of me ( as opposed to be something like smolt --enable-monthly cmd that either get run by user of by something else like firstboot ) Moving systemd service RFEs to rawhide. At this point, it is not appropriate in the Fedora 15 cycle to add these. Furthermore, at this point, we are still finalizing the packaging guidelines to handle SysV -> systemd upgrades. We therefore request: - wait until there are packaging guidelines (this will be announced on the devel list). This ensures that upgrades will work smoothly and we/you won't have to do multiple sets of changes. - work on these sorts of changes for Fedora 16 where necessary, not Fedora 15, as we're trying to fix things for release. - do *not* change a service from SysV to systemd in an existing release (such as Fedora 15), as this is the sort of behavior change that goes against our update policy, documented as https://fedoraproject.org/wiki/Updates_Policy What's the current status on this? Please follow the following guidelines to package the service correctly. https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd http://fedoraproject.org/wiki/Packaging:Tmpfiles.d Will what's the hold up ? 1.4.3-4 removed the pointless initscript and 1.4.3-5.fc16 is stable now. |