| Summary: | Review Request: sugar-surf - Web Browser activity for Sugar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Sergio Pascual <sergio.pasra> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, notting, sergio.pasra |
| Target Milestone: | --- | Flags: | sergio.pasra:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-27 10:20:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Peter Robinson
2011-04-18 22:40:56 UTC
Any update on this? I'm on it. I've been offline during Easter Package is APPROVED, anyway there's one thing that should be fixed. COPYING appears twice, once in doc and another one in /usr/share/sugar/activities/Surf.activity/COPYING + rpmlint says sugar-surf.noarch: W: non-standard-group Sugar/Activities sugar-surf.noarch: E: invalid-lc-messages-dir /usr/share/locale/cpp/LC_MESSAGES/org.laptop.Surf.mo This one can be safely ignored sugar-surf.src: W: non-standard-group Sugar/Activities + naming is ok (follows sugar guidelines) + Spec file name matches package name + Package meets the Packaging Guidelines + License is ok (GPLv2+) + License text is included in doc + Spec file in American English, it is legible + Source matches upstream + Package builds + Build dependencies are listed + Locales are handled using %find_lang + Package doesn't bundle system libraries + Package owns directories it creates (Surf.activity) -- - Files are not duplicated in %files COPYING appears twice, once in doc and another one in /usr/share/sugar/activities/Surf.activity/COPYING + Permissions are set properly + Macros are used consistently + Package contains code + Builds in mock (In reply to comment #3) > Package is APPROVED, anyway there's one thing that should be fixed. Can you set the review flag to approved. > COPYING appears twice, once in doc and another one in > /usr/share/sugar/activities/Surf.activity/COPYING I'll fix it before i commit it (I've fixed it locally). Upss, done! New Package GIT Request ======================= Package Name: sugar-surf Short Description: Web Browser activity for Sugar Owners: pbrobinson Branches: F-15 F-14 EL-6 InitialCC: Git done (by process-git-requests). In rawhide, thanks for the review. Dennis, thanks for the git request. |