Bug 697697 - Review Request: sugar-surf - Web Browser activity for Sugar
Summary: Review Request: sugar-surf - Web Browser activity for Sugar
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sergio Pascual
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-18 22:40 UTC by Peter Robinson
Modified: 2011-04-27 10:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-27 10:20:46 UTC
Type: ---
Embargoed:
sergio.pasra: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Peter Robinson 2011-04-18 22:40:56 UTC
SPEC: http://pbrobinson.fedorapeople.org/sugar-surf.spec
SRPM: http://pbrobinson.fedorapeople.org/sugar-surf-115-1.fc14.src.rpm

Desciption: Surf is a Web browser built on WebKit and thus uses the same 
HTML rendering engine as Epiphany.

Comment 1 Peter Robinson 2011-04-25 08:46:02 UTC
Any update on this?

Comment 2 Sergio Pascual 2011-04-25 13:51:48 UTC
I'm on it. I've been offline during Easter

Comment 3 Sergio Pascual 2011-04-25 22:44:38 UTC
Package is APPROVED, anyway there's one thing that should be fixed. COPYING appears twice, once in doc and another one in /usr/share/sugar/activities/Surf.activity/COPYING

+ rpmlint says
sugar-surf.noarch: W: non-standard-group Sugar/Activities
sugar-surf.noarch: E: invalid-lc-messages-dir /usr/share/locale/cpp/LC_MESSAGES/org.laptop.Surf.mo This one can be safely ignored 
sugar-surf.src: W: non-standard-group Sugar/Activities

+ naming is ok (follows sugar guidelines)
+ Spec file name matches package name
+ Package meets the Packaging Guidelines
+ License is ok (GPLv2+)
+ License text is included in doc
+ Spec file in American English, it is legible
+ Source matches upstream
+ Package builds
+ Build dependencies are listed
+ Locales are handled using %find_lang
+ Package doesn't bundle system libraries
+ Package owns directories it creates (Surf.activity) --
- Files are not duplicated in %files

COPYING appears twice, once in doc and another one in /usr/share/sugar/activities/Surf.activity/COPYING

+ Permissions are set properly
+ Macros are used consistently
+ Package contains code
+ Builds in mock

Comment 4 Peter Robinson 2011-04-26 12:35:09 UTC
(In reply to comment #3)
> Package is APPROVED, anyway there's one thing that should be fixed. 

Can you set the review flag to approved.

> COPYING appears twice, once in doc and another one in
> /usr/share/sugar/activities/Surf.activity/COPYING

I'll fix it before i commit it (I've fixed it locally).

Comment 5 Sergio Pascual 2011-04-26 13:34:46 UTC
Upss, done!

Comment 6 Peter Robinson 2011-04-26 13:46:23 UTC
New Package GIT Request
=======================
Package Name: sugar-surf
Short Description: Web Browser activity for Sugar
Owners: pbrobinson
Branches: F-15 F-14 EL-6
InitialCC:

Comment 7 Dennis Gilmore 2011-04-26 21:49:52 UTC
Git done (by process-git-requests).

Comment 8 Peter Robinson 2011-04-27 10:20:46 UTC
In rawhide, thanks for the review.

Dennis, thanks for the git request.


Note You need to log in before you can comment on or make changes to this bug.