Bug 697850
| Summary: | Child Resources subtab refreshes twice | ||
|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | John Mazzitelli <mazz> |
| Component: | Core UI | Assignee: | Jay Shaughnessy <jshaughn> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 4.0.0.Beta1 | CC: | ccrouch, hrupp, jshaughn |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 4.1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-03 16:57:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 705059, 715334 | ||
|
Description
John Mazzitelli
2011-04-19 12:58:14 UTC
I'm not sure there are really two loads here. When switching subtabs I only see one call to fetch the children (findResourceCompositesByCriteria()). When navigating directly (via, say, the back button or a browser url when not currently in the resource detail view) there are in fact two calls to findResourceCompositesByCriteria(). But, this is expected. We always call findResourceCompositesByCriteria() when loading a resource detail view, that call loads the target resource. The second call then loads the children. paraphrased from mazz: "the issue is a visible redraw of the list grid contents. Whether or not this is tied to an unnecessary db fetch is not known. The spinner spins, though. But, at last try it did not reproduce." I suggest we drop prio on this and move to jon3 from rhq4. Stopping work for now. Unassigning as work is stopped Note, this issue actually affects all subtabs (or all that implement RefreshableView, which may be all of them). There is a separate BZ for the same issue on the Configuration>Current subtab (https://bugzilla.redhat.com/show_bug.cgi?id=704742), which is a bit different than most subtabs, because it is not a Table. commit ecd63ba59b3e985481dc76de3044dfad656a8dd2 Author: Jay Shaughnessy <jshaughn> Date: Wed May 18 15:22:25 2011 -0400 For the resource and group detail views (The two level tab views) ensure that for RefreshableViews the subtab canvas is not rendered until after refresh() is called on the canvas. This allows the refresh method to clear stale data from an existing canvas before initiating the async pull of new data, preventing the user from briefly seeing the stale data and then having the refresh kick in (which can look a lot like an unnecessary refresh) For Tables this works well without any changes to the refresh() method. That's because the ds invalidateCache method clears the grid. Other views may have to ensure the canvas is presentable in the refresh impl. This commit includes a change like this for the current resource config view. Note that the other 3 config views (resPlugin, groupPlugin, groupConf) already handled this as needed. verified. Bulk closing of old issues that are in VERIFIED state. |