| Summary: | Review Request: perl-DublinCore-Record - Container for Dublin Core metadata elements | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicholas van Oudtshoorn <vanoudt> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-DublinCore-Record-0.03-2.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-02 21:53:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Nicholas van Oudtshoorn
2011-04-28 08:03:12 UTC
Nicholas has a sponsor - no need to block FE-NEEDSPONSOR any more. Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3521258 + rpmlint on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source match with upstream as (sha1sum) 5fab8fcb9307b787de3831ff9e875c2a5f427bd5 DublinCore-Record-0.03.tar.gz 5fab8fcb9307b787de3831ff9e875c2a5f427bd5 ../SOURCES/DublinCore-Record-0.03.tar.gz + make test gave All tests successful. Files=6, Tests=135, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.15 cusr 0.02 csys = 0.21 CPU) Result: PASS + Package: perl-DublinCore-Record-0.03-1.fc17.noarch Provides: perl(DublinCore::Element) = 0.03 perl(DublinCore::Record) = 0.03 Requires: perl(Carp) perl(Class::Accessor) perl(DublinCore::Element) perl(base) perl(strict) perl(warnings) + Follows packaging guidelines Suggestions: 1) If building this on Fedora only then you don't need a) buidlroot b) cleaning of buildroot in %install c) %clean section d) defattr(-,root,root,-) 2) yum will install automatically dependencies so remove perl(Class::Accessor) as Requires: 3)Changelog should add email address. See http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs ping any updates here? Finally - an update! A new spec file and SRPM based on the comments above: Spec URL: http://dl.dropbox.com/u/8648526/packaging/perl-DublinCore-Record.spec SRPM URL: http://dl.dropbox.com/u/8648526/packaging/perl-DublinCore-Record-0.03-2.fc16.src.rpm Review:- + koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3545436 + rpmlint on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + source verified with upstream as (sha1sum) 5fab8fcb9307b787de3831ff9e875c2a5f427bd5 DublinCore-Record-0.03.tar.gz 5fab8fcb9307b787de3831ff9e875c2a5f427bd5 ../SOURCES/DublinCore-Record-0.03.tar.gz + ./Build test gave All tests successful. Files=6, Tests=135, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.15 cusr 0.02 csys = 0.22 CPU) + Package: perl-DublinCore-Record-0.03-2.fc17.noarch Provides: perl(DublinCore::Element) = 0.03 perl(DublinCore::Record) = 0.03 Requires: perl(Carp) perl(Class::Accessor) perl(DublinCore::Element) perl(base) perl(strict) perl(warnings) + rest follows packaging guidelines APPROVED. Please include an SCM request. New Package SCM Request ======================= Package Name: perl-DublinCore-Record Short Description: DublinCore::Record is an abstract class for manipulating DublinCore meta-data. Owners: vanoudt Branches: f15 f16 InitialCC: perl-sig Can you build the package? New Package SCM Request ======================= Package Name: perl-DublinCore-Record Short Description: DublinCore::Record is an abstract class for manipulating DublinCore meta-data. Owners: vanoudt Branches: f16 InitialCC: perl-sig Git done (by process-git-requests). perl-DublinCore-Record-0.03-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-DublinCore-Record-0.03-2.fc16 perl-DublinCore-Record-0.03-2.fc16 has been pushed to the Fedora 16 testing repository. perl-DublinCore-Record-0.03-2.fc16 has been pushed to the Fedora 16 stable repository. |