Bug 700352 - Review Request: perl-DublinCore-Record - Container for Dublin Core metadata elements
Summary: Review Request: perl-DublinCore-Record - Container for Dublin Core metadata e...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-28 08:03 UTC by Nicholas van Oudtshoorn
Modified: 2012-01-02 21:53 UTC (History)
4 users (show)

Fixed In Version: perl-DublinCore-Record-0.03-2.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-02 21:53:54 UTC
Type: ---
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Nicholas van Oudtshoorn 2011-04-28 08:03:12 UTC
Spec URL: http://dl.dropbox.com/u/8648526/perl-DublinCore-Record.spec
SRPM URL: http://dl.dropbox.com/u/8648526/perl-DublinCore-Record-0.03-1.fc14.src.rpm
Description:

DublinCore::Record is an abstract class for manipulating DublinCore
meta-data. The Dublin Core is a small set of meta-data elements for
describing information resources. For more information on embedding
DublinCore in HTML see RFC 2731 http://www.ietf.org/rfc/rfc2731 or
http://www.dublincore.org/documents/dces/

This is one of the requirements for the Koha Library Management System.

Since I have not yet got any packages in the fedora repository, I am looking for a sponsor.

Comment 1 Iain Arnell 2011-10-27 03:02:36 UTC
Nicholas has a sponsor - no need to block FE-NEEDSPONSOR any more.

Comment 2 Parag AN(पराग) 2011-11-17 06:35:00 UTC
Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3521258

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source match with upstream as (sha1sum)
5fab8fcb9307b787de3831ff9e875c2a5f427bd5  DublinCore-Record-0.03.tar.gz
5fab8fcb9307b787de3831ff9e875c2a5f427bd5  ../SOURCES/DublinCore-Record-0.03.tar.gz

+ make test gave
All tests successful.
Files=6, Tests=135,  0 wallclock secs ( 0.04 usr  0.00 sys +  0.15 cusr  0.02 csys =  0.21 CPU)
Result: PASS

+ Package: perl-DublinCore-Record-0.03-1.fc17.noarch
Provides: perl(DublinCore::Element) = 0.03 perl(DublinCore::Record) = 0.03
Requires: perl(Carp) perl(Class::Accessor) perl(DublinCore::Element) perl(base) perl(strict) perl(warnings)

+ Follows packaging guidelines

Suggestions:
1) If building this on Fedora only then you don't need
  a) buidlroot
  b) cleaning of buildroot in %install
  c) %clean section
  d) defattr(-,root,root,-)

2) yum will install automatically dependencies so remove perl(Class::Accessor) as Requires:

3)Changelog should add email address. See http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs

Comment 3 Parag AN(पराग) 2011-11-28 03:54:15 UTC
ping any updates here?

Comment 4 Nicholas van Oudtshoorn 2011-11-28 05:17:05 UTC
Finally - an update! A new spec file and SRPM based on the comments above:

Spec URL: http://dl.dropbox.com/u/8648526/packaging/perl-DublinCore-Record.spec
SRPM URL:
http://dl.dropbox.com/u/8648526/packaging/perl-DublinCore-Record-0.03-2.fc16.src.rpm

Comment 5 Parag AN(पराग) 2011-11-28 07:22:55 UTC
Review:-

+ koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3545436

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ source verified with upstream as  (sha1sum)
5fab8fcb9307b787de3831ff9e875c2a5f427bd5  DublinCore-Record-0.03.tar.gz
5fab8fcb9307b787de3831ff9e875c2a5f427bd5  ../SOURCES/DublinCore-Record-0.03.tar.gz

+ ./Build test gave
All tests successful.
Files=6, Tests=135,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.15 cusr  0.02 csys =  0.22 CPU)

+ Package: perl-DublinCore-Record-0.03-2.fc17.noarch
Provides: perl(DublinCore::Element) = 0.03 perl(DublinCore::Record) = 0.03
Requires: perl(Carp) perl(Class::Accessor) perl(DublinCore::Element) perl(base) perl(strict) perl(warnings)

+ rest follows packaging guidelines


APPROVED.

Comment 6 Gwyn Ciesla 2011-12-13 01:50:02 UTC
Please include an SCM request.

Comment 7 Nicholas van Oudtshoorn 2011-12-13 01:58:15 UTC
New Package SCM Request
=======================
Package Name: perl-DublinCore-Record
Short Description: DublinCore::Record is an abstract class for manipulating DublinCore meta-data.
Owners: vanoudt
Branches: f15 f16
InitialCC: perl-sig

Comment 8 Parag AN(पराग) 2011-12-21 10:22:17 UTC
Can you build the package?

Comment 9 Nicholas van Oudtshoorn 2011-12-22 01:32:10 UTC
New Package SCM Request
=======================
Package Name: perl-DublinCore-Record
Short Description: DublinCore::Record is an abstract class for manipulating
DublinCore meta-data.
Owners: vanoudt
Branches: f16
InitialCC: perl-sig

Comment 10 Gwyn Ciesla 2011-12-22 13:15:48 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2011-12-23 01:59:24 UTC
perl-DublinCore-Record-0.03-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-DublinCore-Record-0.03-2.fc16

Comment 12 Fedora Update System 2011-12-23 22:23:30 UTC
perl-DublinCore-Record-0.03-2.fc16 has been pushed to the Fedora 16 testing repository.

Comment 13 Fedora Update System 2012-01-02 21:53:54 UTC
perl-DublinCore-Record-0.03-2.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.