Bug 700354
Summary: | Review Request: perl-Locale-Currency-Format - Perl functions for formatting monetary values | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicholas van Oudtshoorn <vanoudt> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | fedora-package-review, iarnell, notting, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Locale-Currency-Format-1.30-1.fc16 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-01-02 21:50:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nicholas van Oudtshoorn
2011-04-28 08:06:30 UTC
Nicholas has a sponsor - no need to block FE-NEEDSPONSOR any more. Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3521246 + rpmlint on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source match with upstream as (sha1sum) 6b1028c91b3038dc6d04ce62ba67ccb6af3900b5 Locale-Currency-Format-1.28.tar.gz 6b1028c91b3038dc6d04ce62ba67ccb6af3900b5 ../SOURCES/Locale-Currency-Format-1.28.tar.gz + make test All tests successful. Files=1, Tests=26, 0 wallclock secs ( 0.02 usr + 0.01 sys = 0.03 CPU) + Package: perl-Locale-Currency-Format-1.28-1.fc17.noarch Provides: perl(Locale::Currency::Format) = 1.28 Requires: perl >= 0:5.006_00 perl(Exporter) perl(strict) + Follows packaging guidelines Suggestions: 1) If building this on Fedora only then you don't need a) buidlroot b) cleaning of buildroot in %install c) %clean section d) defattr(-,root,root,-) Looks like also your changelog is missing the standard format of adding email address also. See http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs New spec file and SRPM uploaded: Spec URL: http://dl.dropbox.com/u/8648526/packaging/perl-Locale-Currency-Format.spec SRPM URL: http://dl.dropbox.com/u/8648526/packaging/perl-Locale-Currency-Format-1.30-1.fc16.src.rpm koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3545438 APPROVED. New Package SCM Request ======================= Package Name: perl-Locale-Currency-Format Short Description: Locale::Currency::Format is a light-weight Perl module that enables Perl code to display monetary values in the formats recognized internationally and/or locally. Owners: vanoudt Branches: f15 f16 InitialCC: perl-sig Git done (by process-git-requests). Can you build the package? perl-Locale-Currency-Format-1.30-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Locale-Currency-Format-1.30-1.fc16 perl-Locale-Currency-Format-1.30-1.fc16 has been pushed to the Fedora 16 testing repository. perl-Locale-Currency-Format-1.30-1.fc16 has been pushed to the Fedora 16 stable repository. |