Bug 700354 - Review Request: perl-Locale-Currency-Format - Perl functions for formatting monetary values
Summary: Review Request: perl-Locale-Currency-Format - Perl functions for formatting m...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-28 08:06 UTC by Nicholas van Oudtshoorn
Modified: 2012-01-02 21:50 UTC (History)
4 users (show)

Fixed In Version: perl-Locale-Currency-Format-1.30-1.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-02 21:50:58 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Nicholas van Oudtshoorn 2011-04-28 08:06:30 UTC
Spec URL: http://dl.dropbox.com/u/8648526/perl-Locale-Currency-Format.spec
SRPM URL: http://dl.dropbox.com/u/8648526/perl-Locale-Currency-Format-1.28-1.fc14.src.rpm
Description:

Locale::Currency::Format is a light-weight Perl module that enables Perl
code to display monetary values in the formats recognized internationally
and/or locally.

This is one of the requirements for the Koha Library Management System.

Since I have not yet got any packages in the fedora repository, I am looking for a sponsor.

Comment 1 Iain Arnell 2011-10-27 03:03:26 UTC
Nicholas has a sponsor - no need to block FE-NEEDSPONSOR any more.

Comment 2 Parag AN(पराग) 2011-11-17 06:23:59 UTC
Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3521246

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source match with upstream as (sha1sum)
6b1028c91b3038dc6d04ce62ba67ccb6af3900b5  Locale-Currency-Format-1.28.tar.gz
6b1028c91b3038dc6d04ce62ba67ccb6af3900b5  ../SOURCES/Locale-Currency-Format-1.28.tar.gz

+ make test
All tests successful.
Files=1, Tests=26,  0 wallclock secs ( 0.02 usr +  0.01 sys =  0.03 CPU)

+ Package: perl-Locale-Currency-Format-1.28-1.fc17.noarch
Provides: perl(Locale::Currency::Format) = 1.28
Requires: perl >= 0:5.006_00 perl(Exporter) perl(strict)

+ Follows packaging guidelines

Suggestions:
1) If building this on Fedora only then you don't need
  a) buidlroot
  b) cleaning of buildroot in %install
  c) %clean section
  d) defattr(-,root,root,-)

Comment 3 Parag AN(पराग) 2011-11-17 06:33:43 UTC
Looks like also your changelog is missing the standard format of adding email address also. See http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs

Comment 5 Parag AN(पराग) 2011-11-28 09:18:09 UTC
koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3545438

APPROVED.

Comment 6 Nicholas van Oudtshoorn 2011-12-13 02:05:19 UTC
New Package SCM Request
=======================
Package Name: perl-Locale-Currency-Format
Short Description: Locale::Currency::Format is a light-weight Perl module that enables Perl code to display monetary values in the formats recognized internationally and/or locally.
Owners: vanoudt
Branches: f15 f16
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2011-12-13 02:39:43 UTC
Git done (by process-git-requests).

Comment 8 Parag AN(पराग) 2011-12-21 10:22:10 UTC
Can you build the package?

Comment 9 Fedora Update System 2011-12-23 02:07:17 UTC
perl-Locale-Currency-Format-1.30-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-Locale-Currency-Format-1.30-1.fc16

Comment 10 Fedora Update System 2011-12-23 22:18:37 UTC
perl-Locale-Currency-Format-1.30-1.fc16 has been pushed to the Fedora 16 testing repository.

Comment 11 Fedora Update System 2012-01-02 21:50:58 UTC
perl-Locale-Currency-Format-1.30-1.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.