Bug 700587

Summary:	Review Request: surfer - visualization of algebraic geometry
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mario.blaettermann, martin.gieseking, notting
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-05-04 20:45:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	697680
Bug Blocks:

Description Jerry James 2011-04-28 18:04:32 UTC

Spec URL: http://jjames.fedorapeople.org/surfer/surfer.spec
SRPM URL: http://jjames.fedorapeople.org/surfer/surfer-0.0.304-1.fc14.src.rpm
Description: Surfer is a program to visualize real algebraic geometry in real-time.  The surfaces visualized are given by the zero set of a polynomial equation in 3 variables.  Surfer is based on the program Surf (surf-geometry in Fedora, due to a name clash) and has been developed for the exhibition IMAGINARY, organized by the Mathematisches Forschungsinstitut Oberwolfach and created for the Year of Mathematics 2008 in Germany.

This package is an optional component of SINGULAR, which is a component of SAGE.

Comment 1 Mario Blättermann 2011-05-08 11:00:38 UTC

%{_datadir}/surfer
%exclude %{_datadir}/surfer/gallery

These directories and their contents are not properly owned by your package. Please put a / after the name to do so.

http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory

Comment 2 Martin Gieseking 2011-05-08 18:12:43 UTC

(In reply to comment #1)

> These directories and their contents are not properly owned by your package.
> Please put a / after the name to do so.

The trailing slash is optional. It doesn't add any semantics to the path expression. However, it could help packagers to visually distinguish between files and folders.

Comment 3 Mario Blättermann 2011-05-08 19:00:16 UTC

(In reply to comment #2)
> (In reply to comment #1)
> 
> > These directories and their contents are not properly owned by your package.
> > Please put a / after the name to do so.
> 
> The trailing slash is optional. It doesn't add any semantics to the path
> expression. However, it could help packagers to visually distinguish between
> files and folders.

Anyway, this is the style as mentioned in the packaging guidelines. And yes, it helps packagers and reviewers, really. Sometimes it is difficult to keep track of the validity in the filelist.

Comment 4 Jerry James 2011-05-19 15:45:36 UTC

(In reply to comment #1)
> %{_datadir}/surfer
> %exclude %{_datadir}/surfer/gallery
> 
> These directories and their contents are not properly owned by your package.
> Please put a / after the name to do so.

That is incorrect.  Those directories and their contents ARE properly owned by the package, as I already pointed out when you made the same comment about the surf-geometry package.  Please stop making this false claim.

Comment 5 Mario Blättermann 2011-05-31 20:02:14 UTC

Sorry for the blurb. The folder are properly owned by your package. I was a bit mislead by the packaging guidelines.

Comment 6 Jerry James 2012-05-04 20:45:08 UTC

Further experience shows that this software is too unstable, and upstream is essentially dead.  I am withdrawing this review request.  Users of Singular will have to look elsewhere for a visualizer.