Bug 701937

Summary:	Review Request: python-rope - Python refactoring library
Product:	[Fedora] Fedora	Reporter:	Stanislav Ochotnicky <sochotni>
Component:	Package Review	Assignee:	Daiki Ueno <dueno>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dueno, fedora-package-review, notting
Target Milestone:	---	Flags:	dueno: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-13 09:49:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	701954

Description Stanislav Ochotnicky 2011-05-04 11:26:15 UTC

Spec URL: http://sochotni.fedorapeople.org/packages/rope.spec
SRPM URL: http://sochotni.fedorapeople.org/packages/rope-0.9.3-1.fc14.src.rpm

Description:
Rope is a python refactoring library. Some of the main features
include:
 * Rename everything!
 * Extract method/local variable
 * Move class/function/module/package/method
 * Inline method/local variable/parameter
 * Restructuring (like converting "${a}.f(${b})" to "${b}.g(${a})" where "a: type=mymod.A")
 * Introduce factory
 * Change method signature
 * Transform module to package
 * Encapsulate field
 * Replace method with method object
 * And a few others

Comment 1 Daiki Ueno 2011-05-13 05:18:00 UTC

I'll take this as well as bug 701932.  Hope ropemacs will be integrated in Fedora soon :)

The packaging looks fine.  It mostly complies with the general, Python, and Python Eggs packaging guidelines.  A couple of minor issues:

1. Python addon packages seems to be suggested to prefix "python-"
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29

2. README.txt refers to documentation files under docs, which are not packaged

Comment 2 Stanislav Ochotnicky 2011-05-13 08:52:19 UTC

Thanks for taking this. I'll fix up ropemode and ropemacs in the meantime

* Fri May 13 2011 Stanislav Ochotnicky <sochotnicky> - 0.9.3-2
- Changed name from rope to python-rope
- Fixed license to GPLv2+
- Added documentation files

Spec URL: http://sochotni.fedorapeople.org/packages/python-rope.spec
SRPM URL: http://sochotni.fedorapeople.org/packages/python-rope-0.9.3-2.fc14.src.rpm

Comment 3 Stanislav Ochotnicky 2011-05-13 09:49:09 UTC

Oh. I somehow missed that there already is python-rope in Fedoras (I guess due to naming...). Closing