Spec URL: http://sochotni.fedorapeople.org/packages/ropemode.spec SRPM URL: http://sochotni.fedorapeople.org/packages/ropemode-0.1-0.1.rc2.fc14.src.rpm Description: Ropemode is a helper library for use of rope refactoring from within IDEs, mainly used by ropemacs within Emacs.
Spec URL: http://sochotni.fedorapeople.org/packages/python-ropemode.spec SRPM URL: http://sochotni.fedorapeople.org/packages/python-ropemode-0.1-0.2.rc2.fc14.src.rpm * Fri May 13 2011 Stanislav Ochotnicky <sochotnicky> - 0.1-0.2.rc2 - Rename to python-ropemode - Fix BR/R on rope to python-rope
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [-]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present See issue below, though. [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required See issue below. [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 See issue below. [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [!]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [!]: MUST Requires correct, justified where necessary. rope dependency not listed. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/mk/tmp/701954/ropemode-0.1-rc2.tar.gz : MD5SUM this package : 005556053583a81f248828adc646924d MD5SUM upstream package : 005556053583a81f248828adc646924d [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: The handling of RHEL5 seems inconsistent. Either it's supported, and Buildroot, %clean, %defattr et. al. are needed. Or it's not supported, and the python macro definitions in the top lines can be removed.Or? [!] The test for %fedora > 12 is redundant and could be removed. [!] PKG-INFO seems to be only file stating the license. Include it in %doc. [!] BR: python2-devel is required and missing, assuming that this is a python2 package. rpmlint python-ropemode-0.1-0.2.rc2.fc18.noarch.rpm python-ropemode.noarch: W: spelling-error (3) - To me, you seem to spell better than rpmlint python-ropemode.noarch: W: no-documentation - Fixed by including PKG-INFO 1 packages and 0 specfiles checked; 0 errors, 4 warnings. rpmlint python-ropemode-0.1-0.2.rc2.fc18.src.rpm python-ropemode.src: W: spelling-error (3) 1 packages and 0 specfiles checked; 0 errors, 3 warnings. <mock-chroot># rpm -q --provides python-ropemode python-ropemode = 0.1-0.2.rc2.fc15 <mock-chroot># rpm -q --requires python-ropemode | grep -v rpmlib python python(abi) = 2.7 python-rope <mock-chroot># Generated by fedora-review 0.1.3 External plugins:
Thanks for doing the review * Fri May 4 2012 Stanislav Ochotnicky <sochotnicky> - 0.1-0.3.rc2 - Add PKG-INFO to doc (contains license information) - Remove macros for old Fedoras and EPEL5 - Change python-devel BR to python2-devel Spec URL: http://sochotni.fedorapeople.org/packages/python-ropemode.spec SRPM URL: http://sochotni.fedorapeople.org/packages/python-ropemode-0.1-0.3.rc2.fc16.src.rpm
Hm...the spec link link looks like the old one, no change ;) But the srpm looks fine. *** Approved BTW, I noticed that the rpmbuild picks up the python dependency even without Requires: python. That is not to say the Requires: python is a problem.
I assume it was just your cache because I upload with a script :-) Thanks for the review. New Package SCM Request ======================= Package Name: python-ropemode Short Description: Helper for using rope refactoring library in IDEs Owners: sochotni Branches: f16 f17 InitialCC:
Alec, please set the review flag to +.
Done. When will I learn?
Git done (by process-git-requests). Daily. :)
python-ropemode-0.1-0.3.rc2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-ropemode-0.1-0.3.rc2.fc17
python-ropemode-0.1-0.3.rc2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-ropemode-0.1-0.3.rc2.fc16
python-ropemode-0.1-0.3.rc2.fc17 has been pushed to the Fedora 17 testing repository.
python-ropemode-0.1-0.3.rc2.fc17 has been pushed to the Fedora 17 stable repository.
python-ropemode-0.1-0.3.rc2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.