Bug 702869

Created attachment 497584 [details]
File: event_log

Created attachment 497585 [details]
File: build_ids

Created attachment 497586 [details]
File: maps

Created attachment 497587 [details]
File: dsos

Created attachment 497588 [details]
File: backtrace

Works fine for me. Does the plugin crash every time you try to add it?

Package: xfce4-diskperf-plugin-2.3.0-1.fc15
Architecture: x86_64
OS Release: Fedora release 15 (Lovelock)


Comment
-----
add the plugin and it crashes immediately

Ok, after upgrading to F15 I can reproduce the crash. With Xfce 4.8 on F14 however it worked fine.

Looking at the backtrace and the code, it seems that the code manages to hit what seems to be a bug with _FORTIFY_SOURCE.  If I'm debugging this right, it seems that gcc thinks that the buffer being copied into has size 0.

Strangely though, a rebuild on my local machine (with the same version of gcc) fixed the issue.

I was mistaken about the gcc version, both the gcc and glibc versions in my build were newer than what was used to build the original package (-7 vs. -0.7), so that may have been the culprit, and a rebuild is probably the solution to this bug.

Funny thing is, it looks like this was warned about in the build logs for this package.  I have no idea why this isn't an error instead :-)

From http://kojipkgs.fedoraproject.org/packages/xfce4-diskperf-plugin/2.3.0/1.fc15/data/logs/x86_64/build.log:

In file included from /usr/include/string.h:642:0,
                 from /usr/include/glib-2.0/glib/gi18n-lib.h:26,
                 from /usr/include/xfce4/libxfce4util/xfce-i18n.h:33,
                 from /usr/include/xfce4/libxfce4util/libxfce4util.h:34,
                 from config_gui.h:26,
                 from main.c:18:
In function 'strncpy',
    inlined from 'diskperf_create_control' at main.c:422:13,
    inlined from 'diskperf_construct' at main.c:1083:17,
    inlined from '_xpp_realize' at main.c:1114:1:
/usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk will always overflow destination buffer [enabled by default]
In function 'strncpy',
    inlined from 'diskperf_read_config' at main.c:519:17,
    inlined from 'diskperf_construct' at main.c:1108:26,
    inlined from '_xpp_realize' at main.c:1114:1:
/usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk will always overflow destination buffer [enabled by default]

Same thing with latest updates.

(In reply to comment #10)
> In file included from /usr/include/string.h:642:0,
>                  from /usr/include/glib-2.0/glib/gi18n-lib.h:26,
>                  from /usr/include/xfce4/libxfce4util/xfce-i18n.h:33,
>                  from /usr/include/xfce4/libxfce4util/libxfce4util.h:34,
>                  from config_gui.h:26,
>                  from main.c:18:
> In function 'strncpy',
>     inlined from 'diskperf_create_control' at main.c:422:13,
>     inlined from 'diskperf_construct' at main.c:1083:17,
>     inlined from '_xpp_realize' at main.c:1114:1:
> /usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk
> will always overflow destination buffer [enabled by default]
> In function 'strncpy',
>     inlined from 'diskperf_read_config' at main.c:519:17,
>     inlined from 'diskperf_construct' at main.c:1108:26,
>     inlined from '_xpp_realize' at main.c:1114:1:
> /usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk
> will always overflow destination buffer [enabled by default]

Indeed, I don't get these in a rebuild. Stay tuned for an update.

Whenever I enter the bug number in the update, koji gives me an internal error. So I'll just add the link to the update manually:
https://admin.fedoraproject.org/updates/xfce4-diskperf-plugin-2.3.0-2.fc15

xfce4-diskperf-plugin-2.3.0-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/xfce4-diskperf-plugin-2.3.0-2.fc15

xfce4-diskperf-plugin-2.3.0-2.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.