abrt version: 2.0.1 comment: Adding application to panel caused the crash instantly. executable: /usr/libexec/xfce4/panel-plugins/xfce4-diskperf-plugin cmdline: /usr/libexec/xfce4/panel-plugins/xfce4-diskperf-plugin '' 22 19492103 diskperf 'Disk Performance Monitor' 'Show disk performance' '' component: xfce4-diskperf-plugin uid: 500 crash_function: strncpy kernel: 2.6.38.4-20.fc15.x86_64 reason: Process /usr/libexec/xfce4/panel-plugins/xfce4-diskperf-plugin was killed by signal 6 (SIGABRT) architecture: x86_64 username: jussi package: xfce4-diskperf-plugin-2.3.0-1.fc15 os_release: Fedora release 15 (Lovelock) time: 1304802465 rating: 4 Text file: event_log, 12701 bytes Text file: build_ids, 2173 bytes Binary file: coredump, 1523712 bytes Text file: maps, 18372 bytes Text file: dsos, 13561 bytes Text file: backtrace, 16695 bytes environ ----- XDG_SESSION_ID=103 SSH_AGENT_PID=677 HOSTNAME=tb900.no-ip.org IMSETTINGS_INTEGRATE_DESKTOP=yes GPG_AGENT_INFO=/tmp/gpg-GxJCqS/S.gpg-agent:720:1 GLADE_PIXMAP_PATH=: XDG_MENU_PREFIX=xfce- TERM=dumb SHELL=/bin/bash HISTSIZE=1000 XDG_SESSION_COOKIE=db4691a21be34b611f2d7f840000001a-1304627617.669779-21981236 QTDIR=/usr/lib64/qt-3.3 GNOME_KEYRING_CONTROL=/tmp/keyring-rxRUsk QTINC=/usr/lib64/qt-3.3/include IMSETTINGS_MODULE=none USER=jussi GLADE_MODULE_PATH=: SSH_AUTH_SOCK=/tmp/ssh-yNOmpDb552/agent.552 USERNAME=jussi XDG_CONFIG_DIRS=/etc/xdg MAIL=/var/spool/mail/jussi DESKTOP_SESSION=xfce PATH=/usr/lib64/qt-3.3/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/jussi/bin:/home/jussi/dokumentit/bin:/home/jussi/dokumentit/bin/erkale/build:/home/jussi/bin QT_IM_MODULE=xim PWD=/home/jussi XMODIFIERS=@im=none KDE_IS_PRELINKED=1 LANG=en_US.UTF-8 GNOME_KEYRING_PID=544 MODULEPATH=/usr/share/Modules/modulefiles:/etc/modulefiles GDM_LANG= LOADEDMODULES= KDEDIRS=/usr GDMSESSION=xfce SSH_ASKPASS=/usr/libexec/openssh/gnome-ssh-askpass HISTCONTROL=ignoreboth SHLVL=2 HOME=/home/jussi GTK_PATH=:/usr/lib64/gtk-2.0 LOGNAME=jussi QTLIB=/usr/lib64/qt-3.3/lib CVS_RSH=ssh DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-uuw4UAryTw,guid=869d2f29bdb8b1e3ba42576200040ba7 XDG_DATA_DIRS=/usr/local/share:/usr/share MODULESHOME=/usr/share/Modules 'LESSOPEN=||/usr/bin/lesspipe.sh %s' WINDOWPATH=8 DISPLAY=:0.0 XDG_RUNTIME_DIR=/run/user/jussi GLADE_CATALOG_PATH=: LIBGLADE_MODULE_PATH=: G_BROKEN_FILENAMES=1 XAUTHORITY=/var/run/gdm/auth-for-jussi-F2F8mG/database 'module=() { eval `/usr/bin/modulecmd bash $*`\n}' _=/usr/bin/xfce4-session SESSION_MANAGER=local/unix:@/tmp/.ICE-unix/729,unix/unix:/tmp/.ICE-unix/729
Created attachment 497584 [details] File: event_log
Created attachment 497585 [details] File: build_ids
Created attachment 497586 [details] File: maps
Created attachment 497587 [details] File: dsos
Created attachment 497588 [details] File: backtrace
Works fine for me. Does the plugin crash every time you try to add it?
Package: xfce4-diskperf-plugin-2.3.0-1.fc15 Architecture: x86_64 OS Release: Fedora release 15 (Lovelock) Comment ----- add the plugin and it crashes immediately
Ok, after upgrading to F15 I can reproduce the crash. With Xfce 4.8 on F14 however it worked fine.
Looking at the backtrace and the code, it seems that the code manages to hit what seems to be a bug with _FORTIFY_SOURCE. If I'm debugging this right, it seems that gcc thinks that the buffer being copied into has size 0. Strangely though, a rebuild on my local machine (with the same version of gcc) fixed the issue.
I was mistaken about the gcc version, both the gcc and glibc versions in my build were newer than what was used to build the original package (-7 vs. -0.7), so that may have been the culprit, and a rebuild is probably the solution to this bug. Funny thing is, it looks like this was warned about in the build logs for this package. I have no idea why this isn't an error instead :-) From http://kojipkgs.fedoraproject.org/packages/xfce4-diskperf-plugin/2.3.0/1.fc15/data/logs/x86_64/build.log: In file included from /usr/include/string.h:642:0, from /usr/include/glib-2.0/glib/gi18n-lib.h:26, from /usr/include/xfce4/libxfce4util/xfce-i18n.h:33, from /usr/include/xfce4/libxfce4util/libxfce4util.h:34, from config_gui.h:26, from main.c:18: In function 'strncpy', inlined from 'diskperf_create_control' at main.c:422:13, inlined from 'diskperf_construct' at main.c:1083:17, inlined from '_xpp_realize' at main.c:1114:1: /usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk will always overflow destination buffer [enabled by default] In function 'strncpy', inlined from 'diskperf_read_config' at main.c:519:17, inlined from 'diskperf_construct' at main.c:1108:26, inlined from '_xpp_realize' at main.c:1114:1: /usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk will always overflow destination buffer [enabled by default]
Same thing with latest updates.
(In reply to comment #10) > In file included from /usr/include/string.h:642:0, > from /usr/include/glib-2.0/glib/gi18n-lib.h:26, > from /usr/include/xfce4/libxfce4util/xfce-i18n.h:33, > from /usr/include/xfce4/libxfce4util/libxfce4util.h:34, > from config_gui.h:26, > from main.c:18: > In function 'strncpy', > inlined from 'diskperf_create_control' at main.c:422:13, > inlined from 'diskperf_construct' at main.c:1083:17, > inlined from '_xpp_realize' at main.c:1114:1: > /usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk > will always overflow destination buffer [enabled by default] > In function 'strncpy', > inlined from 'diskperf_read_config' at main.c:519:17, > inlined from 'diskperf_construct' at main.c:1108:26, > inlined from '_xpp_realize' at main.c:1114:1: > /usr/include/bits/string3.h:121:3: warning: call to __builtin___strncpy_chk > will always overflow destination buffer [enabled by default] Indeed, I don't get these in a rebuild. Stay tuned for an update.
Whenever I enter the bug number in the update, koji gives me an internal error. So I'll just add the link to the update manually: https://admin.fedoraproject.org/updates/xfce4-diskperf-plugin-2.3.0-2.fc15
xfce4-diskperf-plugin-2.3.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/xfce4-diskperf-plugin-2.3.0-2.fc15
xfce4-diskperf-plugin-2.3.0-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.