Bug 704703
| Summary: | Error processing jpg files, 'module' object has no attribute 'Image' in phatch | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Narasimhan <lakshminaras2002> | ||||||||
| Component: | phatch | Assignee: | Narasimhan <lakshminaras2002> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | rawhide | CC: | hafflys, jguerdat, lakshminaras2002 | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | phatch-0.2.7-7.fc15 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2011-07-04 18:50:48 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Narasimhan
2011-05-14 07:56:02 UTC
Ok. I have a fix for the issue. I will submit an update. phatch-0.2.7-6.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/phatch-0.2.7-6.fc15 phatch-0.2.7-5.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/phatch-0.2.7-5.fc14 phatch-0.2.7-6.fc15 works fine for my limited test. Yay! Hi Jeff, Thanks for testing. If possible, could you test with a image which has some exif tags and see whether the resultant image has the same set of exif tags? I am seeing that some exif tags are not present after phatch processes it. I am still investigating this issue. If I am not able to find a solution or reason for this, I will probably pull out the update. Another update. The exif tag issue is solved. There are two other issues with api compatibility , one related to saving comments and another related to thumbnail data. I am working on those issues now. Issues reported in comment 6 are fixed. Will submit a new update. I have bumped the the evr to 0.2.7-7 just to avoid any problems with the update. phatch-0.2.7-7.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/phatch-0.2.7-7.fc15 phatch-0.2.7-6.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/phatch-0.2.7-6.fc14 I'm not up on EXIF info but the latest update certainly looks better than the previous in this regard. The one thing I note is that the "Maker Note" section (don't know if that's how it's actually identified or if that's what EOG viewer calls it) is noticeably different, with many items removed and others with invalid data. I personally don't care but I won't speak for others. Hi Jeff, Do you see missing information or invalid data with this new update or was it with the previous one? Please confirm. 0.2.7.6-f15 definitely had missing data relative to both the original images as well as 0.2.7.7-f15. 0.2.7.7-f15 is the one that I noticed the invalid data in - I never got that far in 0.2.7.6-f15 what with the additional missing data. Thanks for testing, Do you mean that the new picture and the original have same values for all the exif tags (including invalid data in both cases) for 0.2.7.7-f15 . I tested with a picture locally. All fields in the original and new one are same. The Maker note field has increased in size but eog shows invalid data in both cases. Package phatch-0.2.7-7.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing phatch-0.2.7-7.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/phatch-0.2.7-7.fc15 then log in and leave karma (feedback). Actually, the Phatch'ed image has a smaller Maker Notes section compared to the original and has fields that the original doesn't. The original has no invalid data. I'm attaching a snapshot with the Phatch image properties on the left and the original on the right. It's not complete but gives you the idea. I can upload both images for your own comparison if you like. Created attachment 509928 [details]
comparison of Phatch data on left and original on right
Hi Jeff, I checked the attachment. Looks like those tags with invalid data are not valid exif at all but need to confirm why they are showing up in the first place. If you could share the images, that will be helpful. Thanks, Created attachment 509959 [details]
original image
Created attachment 509960 [details]
image after resized by Phatch
for comparison with original EXIF data
Original and modified images uploaded for EXIF comparison. Thanks Jeff. Marker Note seems to be a proprietary part of the metadata. I will see whether the existing data can in some way be just retained. I will also check how phatch works with previous version of pyexiv2 to see how this marker note is handled. phatch-0.2.7-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. phatch-0.2.7-7.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |