Bug 705016
Summary: | Modifying ATTR_SUBMISSION value on job leads to crash | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise MRG | Reporter: | Martin Kudlej <mkudlej> | ||||
Component: | condor-aviary | Assignee: | Pete MacKinnon <pmackinn> | ||||
Status: | CLOSED ERRATA | QA Contact: | Martin Kudlej <mkudlej> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | 2.0 | CC: | iboverma, matt, tstclair | ||||
Target Milestone: | 2.1 | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | condor-7.6.4-0.4 | Doc Type: | Bug Fix | ||||
Doc Text: |
The Aviary query server could have eventually crashed when the ATTR_SUBMISSION_NAME attribute on a job was modified through the Aviary API after it had been added to the job queue, then removed, followed by an invocation of getJobDetails. This update corrects the code so that ATTR_SUBMISSION_NAME is prevented from being modified after the job has been submitted, which prevents the possibility of an eventual Aviary query server crash.
|
Story Points: | --- | ||||
Clone Of: | Environment: | ||||||
Last Closed: | 2012-01-23 17:26:48 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 743350 | ||||||
Attachments: |
|
Description
Martin Kudlej
2011-05-16 12:27:50 UTC
Created attachment 499126 [details]
log files and configuration
Changing a submission name is disruptive since the name is a key into an internal map. This is not a scenario that has been tested in development nor expressed as a requirement for QMF or Aviary. Complicating matters is that a submission is open-ended and could encompass jobs that are "live" in the queue with writeable attributes as well as jobs recorded to the history log whose attributes are "frozen" permanently. It's trivial to change this particular case to ensure that submission names can't be modified after they enter into the system. However, we should generally revisit the notion of how we expose attributes for modification to a remote user. Do we maintain a table of RW vs. RO attributes? Special case sensitive attributes like ATTR_SUBMISSION? Food for thought... Modified to prevent submission name changes on attribute set in QMF & Aviary *** Bug 705052 has been marked as a duplicate of this bug. *** Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Cause: Modification of the ATTR_SUBMISSION_NAME attribute on a job through Aviary API after it has been added to job queue, removed, then getJobDetails invoked. Consequence: Eventual crash of Aviary query server. Fix: Implemented guard in setJobAttribute implementation that prevents modification of ATTR_SUBMISSION_NAME post-submission. Result: Query server does not crash. Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1,4 +1 @@ -Cause: Modification of the ATTR_SUBMISSION_NAME attribute on a job through Aviary API after it has been added to job queue, removed, then getJobDetails invoked. +The Aviary query server could have eventually crashed when the ATTR_SUBMISSION_NAME attribute on a job was modified through the Aviary API after it had been added to the job queue, then removed, followed by an invocation of getJobDetails. This update corrects the code so that ATTR_SUBMISSION_NAME is prevented from being modified after the job has been submitted, which prevents the possibility of an eventual Aviary query server crash.-Consequence: Eventual crash of Aviary query server. -Fix: Implemented guard in setJobAttribute implementation that prevents modification of ATTR_SUBMISSION_NAME post-submission. -Result: Query server does not crash. Tested on RHEL 5.7/6.2 x x86_64/i386 with condor-ec2-enhanced-hooks-1.2-4 condor-classads-7.6.5-0.7 condor-debuginfo-7.6.5-0.7 python-condorutils-1.5-4 condor-wallaby-base-db-1.16-2 condor-7.6.5-0.7 condor-qmf-7.6.5-0.7 condor-kbdd-7.6.5-0.7 condor-wallaby-client-4.1.2-1 python-condorec2e-1.2-4 condor-job-hooks-1.5-4 condor-ec2-enhanced-1.2-3 condor-wallaby-tools-4.1.2-1 condor-aviary-7.6.5-0.7 and it works. -->VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-0045.html |