| Summary: | QXL driver: images are not added to cache (code is commented out?) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaniv Kaul <ykaul> |
| Component: | xorg-x11-drv-qxl | Assignee: | Dave Airlie <airlied> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 15 | CC: | airlied, crobinso, hdegoede, jkt, mcepl, sandmann, xgl-maint |
| Target Milestone: | --- | Keywords: | Patch, Triaged |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | [cat:performance] | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-09 00:06:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
This code doesn't appear to commented out in rawhide version at least, so closing (F15 is end of life now). |
Description of problem: I didn't see any images added to the cache (added some red_printf() on the server) when running a F15 guest with xorg-x11-drv-qxl-0.0.21-3.fc15.x86_64 - an XP guest on the same host works and seems to be caching. At least some of the code is commented out (and the image's id = 0): From qxl_image.c: #if 0 /* Add to hash table */ if ((info = insert_image_info (hash))) { info->image = image; info->ref_count = 1; image->descriptor.id = hash; image->descriptor.flags = SPICE_IMAGE_CACHE; #if 0 ErrorF ("added with hash %u\n", hash); #endif } #endif Version-Release number of selected component (if applicable): xorg-x11-drv-qxl-0.0.21-3.fc15.x86_64 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: