Bug 706699 - QXL driver: images are not added to cache (code is commented out?)
Summary: QXL driver: images are not added to cache (code is commented out?)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xorg-x11-drv-qxl
Version: 15
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Dave Airlie
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: [cat:performance]
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-05-22 12:03 UTC by Yaniv Kaul
Modified: 2018-04-11 08:19 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-09 00:06:23 UTC
Type: ---


Attachments (Terms of Use)

Description Yaniv Kaul 2011-05-22 12:03:39 UTC
Description of problem:
I didn't see any images added to the cache (added some red_printf() on the server) when running a F15 guest with xorg-x11-drv-qxl-0.0.21-3.fc15.x86_64 - an XP guest on the same host works and seems to be caching.


At least some of the code is commented out (and the image's id = 0):
From qxl_image.c:
#if 0
        /* Add to hash table */
        if ((info = insert_image_info (hash)))
        {
            info->image = image;
            info->ref_count = 1;

            image->descriptor.id = hash;
            image->descriptor.flags = SPICE_IMAGE_CACHE;

#if 0
            ErrorF ("added with hash %u\n", hash);
#endif
        }
#endif


Version-Release number of selected component (if applicable):
xorg-x11-drv-qxl-0.0.21-3.fc15.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 3 Cole Robinson 2012-07-09 00:06:23 UTC
This code doesn't appear to commented out in rawhide version at least, so closing (F15 is end of life now).


Note You need to log in before you can comment on or make changes to this bug.