Bug 708533

Summary: fails to build without downstream patches
Product: Red Hat Enterprise Linux 6 Reporter: Kamil Dudka <kdudka>
Component: xorg-x11-appsAssignee: Hans de Goede <hdegoede>
Status: CLOSED CURRENTRELEASE QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 6.1Keywords: EasyFix, Patch
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-15 10:35:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed fix none

Description Kamil Dudka 2011-05-27 21:25:24 UTC 
Version-Release number of selected component (if applicable):
xorg-x11-apps-7.4-10.el6


Steps to Reproduce:
1. rpmbuild --define '__patch /bin/true' --rebuild xorg-x11-apps-7.4-10.el6.src.rpm

  
Actual results:
DEBUG: configure: WARNING: unrecognized options: --disable-xprint
DEBUG: + make
DEBUG: make  all-am
DEBUG: make[1]: Entering directory `/builddir/build/BUILD/xorg-x11-apps-7.4/xconsole-1.0.3'
DEBUG: gcc -DHAVE_CONFIG_H -I.     -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -M
DEBUG: xconsole.c:185:45: error: sys/stropts.h: No such file or directory
DEBUG: xconsole.c: In function 'get_pty':
DEBUG: xconsole.c:838: warning: implicit declaration of function 'openpty'
DEBUG: make[1]: Leaving directory `/builddir/build/BUILD/xorg-x11-apps-7.4/xconsole-1.0.3'
DEBUG: make[1]: *** [xconsole.o] Error 1
DEBUG: make: *** [all] Error 2
DEBUG: RPM build errors:
DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.AuIZTY (%build)
DEBUG:     Bad exit status from /var/tmp/rpm-tmp.AuIZTY (%build)


Additional info:
The proposed change is required for Coverity to scan defects in downstream
patches separately.
Comment 1 Kamil Dudka 2011-05-27 21:26:46 UTC 
Created attachment 501402 [details]
proposed fix
Comment 4 Suzanne Logcher 2012-02-14 23:09:51 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.
Comment 6 Hans de Goede 2014-07-15 09:12:50 UTC 
Patch looks good to me, and "The proposed change is required for Coverity to scan defects in downstream patches separately." seems like a good reason to me to add it.
Comment 7 Kamil Dudka 2014-07-15 09:39:19 UTC 
I tried xorg-x11-apps-7.7-6.el6 and the package builds fine without downstream patches, so I believe this bug can be closed as fixed.
Comment 8 Hans de Goede 2014-07-15 10:35:24 UTC 
(In reply to Kamil Dudka from comment #7)
> I tried xorg-x11-apps-7.7-6.el6 and the package builds fine without
> downstream patches, so I believe this bug can be closed as fixed.

Great, thanks! Closing.