Bug 709652

Summary:	TC: GRED in grio mode VQs prio parameter does not work (value doesn't change)
Product:	Red Hat Enterprise Linux 6	Reporter:	Petr Šabata <psabata>
Component:	iproute	Assignee:	Petr Šabata <psabata>
Status:	CLOSED ERRATA	QA Contact:	BaseOS QE Security Team <qe-baseos-security>
Severity:	low	Docs Contact:
Priority:	medium
Version:	6.0	CC:	germanovmichel, ksrot, mmaslano, psabata, rvokal, syeghiay
Target Milestone:	rc	Keywords:	Patch
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	iproute-2.6.32-17.el6	Doc Type:	Bug Fix
Doc Text:	Cause The 'tc' utility ignored GRED options. Consequence 'tc' users couldn't configure certain GRED queue related parameters. Fix The 'tc' utility no longer accidentally .overwrites the user specified options. Result 'tc' users can now reliably define all GRED parameters.	Story Points:	---
Clone Of:	707984	Environment:
Last Closed:	2011-12-06 17:10:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	707984, 711344
Bug Blocks:

Description Petr Šabata 2011-06-01 10:03:43 UTC

+++ This bug was initially created as a clone of Bug #707984 +++

Description of problem:

When I setup a GRED Queue in grio mode, the VQs prio parameter should be configurable. But somehow it is always set to the default value, no matter what value I try to set it to.

Version-Release number of selected component:
Package: iproute-2.6.33-8.fc13(i686) -> tc utility, iproute2-ss100224
Package: kernel-2.6.34.8-68.fc13(i686)

How reproducible:
ALWAYS

Steps to Reproduce:
tc qdisc add dev eth0 root gred setup DPs 3 default 0 grio
tc qdisc change dev eth0 root gred limit 60KB min 15KB max 30KB burst 30 avpkt  576 probability 0.01 DP 0 prio 1
tc qdisc change dev eth0 root gred limit 60KB min 15KB max 30KB burst 30 avpkt 576 probability 0.02 DP 1 prio 2  
tc qdisc change dev eth0 root gred limit 60KB min 15KB max 30KB burst 30 avpkt 576 probability 0.03 DP 2 prio 3 
tc qdisc show dev eth0

Actual results:
qdisc gred 800d: root refcnt 2 
 DP:0 (prio 8) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 21 Scell_log 12
 DP:1 (prio 8) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 20 Scell_log 12
 DP:2 (prio 8) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 19 Scell_log 12

Expected results:
qdisc gred 800d: root refcnt 2 
 DP:0 (prio 1) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 21 Scell_log 12
 DP:1 (prio 2) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 20 Scell_log 12
 DP:2 (prio 3) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 19 Scell_log 12

Additional info:

Comment 1 Petr Šabata 2011-06-01 10:04:34 UTC

This applies to RHEL6 too.
Patch is upstream, cb4bd0ec.

Comment 4 RHEL Program Management 2011-07-05 23:52:32 UTC

This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 5 Petr Šabata 2011-08-11 10:57:57 UTC

Fixed in CVS as tag iproute-2_6_32-17_el6.
The build will be ready once bug 711344 is resolved.

Comment 6 Petr Šabata 2011-08-11 11:16:04 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    The 'tc' utility ignored GRED options.
Consequence
    'tc' users couldn't configure certain GRED queue related parameters.
Fix
    The 'tc' utility no longer accidentally .overwrites the user specified
    options.
Result
    'tc' users can now reliably define all GRED parameters.

Comment 9 errata-xmlrpc 2011-12-06 17:10:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1690.html