Bug 707984 - TC: GRED in grio mode VQs prio parameter does not work (value doesn't change)
Summary: TC: GRED in grio mode VQs prio parameter does not work (value doesn't change)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: iproute
Version: 13
Hardware: i386
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 709652
TreeView+ depends on / blocked
 
Reported: 2011-05-26 13:37 UTC by Germano Veit Michel
Modified: 2011-06-15 05:46 UTC (History)
3 users (show)

Fixed In Version: iproute-2.6.33-9.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 709652 (view as bug list)
Environment:
Last Closed: 2011-06-15 05:36:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Germano Veit Michel 2011-05-26 13:37:57 UTC
Description of problem:

When I setup a GRED Queue in grio mode, the VQs prio parameter should be configurable. But somehow it is always set to the default value, no matter what value I try to set it to.

Version-Release number of selected component:
Package: iproute-2.6.33-8.fc13(i686) -> tc utility, iproute2-ss100224
Package: kernel-2.6.34.8-68.fc13(i686)

How reproducible:
ALWAYS

Steps to Reproduce:
tc qdisc add dev eth0 root gred setup DPs 3 default 0 grio
tc qdisc change dev eth0 root gred limit 60KB min 15KB max 30KB burst 30 avpkt  576 probability 0.01 DP 0 prio 1
tc qdisc change dev eth0 root gred limit 60KB min 15KB max 30KB burst 30 avpkt 576 probability 0.02 DP 1 prio 2  
tc qdisc change dev eth0 root gred limit 60KB min 15KB max 30KB burst 30 avpkt 576 probability 0.03 DP 2 prio 3 
tc qdisc show dev eth0

Actual results:
qdisc gred 800d: root refcnt 2 
 DP:0 (prio 8) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 21 Scell_log 12
 DP:1 (prio 8) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 20 Scell_log 12
 DP:2 (prio 8) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 19 Scell_log 12

Expected results:
qdisc gred 800d: root refcnt 2 
 DP:0 (prio 1) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 21 Scell_log 12
 DP:1 (prio 2) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 20 Scell_log 12
 DP:2 (prio 3) Average Queue 0b Measured Queue 0b  
	 Packet drops: 0 (forced 0 early 0)  
	 Packet totals: 0 (bytes 0)  ewma 3 Plog 19 Scell_log 12

Additional info:

Comment 1 Petr Šabata 2011-05-26 13:53:28 UTC
I cannot reproduce this in f15, iproute-2.6.38.1-4.fc15.x86_64
Now just to find the fix and backport it to f13 and possibly f14...

Comment 2 Germano Veit Michel 2011-05-26 14:21:21 UTC
(In reply to comment #1)
> I cannot reproduce this in f15, iproute-2.6.38.1-4.fc15.x86_64
> Now just to find the fix and backport it to f13 and possibly f14...

It might be this:

diff iproute2-2.6.33/tc/q_gred.c iproute2-2.6.38/tc/q_gred.c
54c54
< 	struct tc_gred_sopt opt;
---
> 	struct tc_gred_sopt opt = { 0 };
86c86
< 			opt.grio=1;
---
> 			opt.grio = 1;
103d102
< 	memset(&opt, 0, sizeof(struct tc_gred_sopt));

Comment 3 Germano Veit Michel 2011-05-26 14:28:43 UTC
Didn't work for me. Might be a kernel problem...

Comment 4 Germano Veit Michel 2011-05-26 14:37:24 UTC
CORRECTION:
That did work. I compiled the unpatched version by mistake. Bug solved.

Thanks

Comment 5 Bug Zapper 2011-05-30 10:30:20 UTC
This message is a reminder that Fedora 13 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 13.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '13'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 13's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 13 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Petr Šabata 2011-06-01 09:53:53 UTC
Germano,

thanks for looking into that.

http://git.kernel.org/?p=linux/kernel/git/shemminger/iproute2.git;a=commit;h=cb4bd0ec8dcba856d1ebf8b3f72b79f669dad0f4

f13/f14 updates are on their way...

Comment 7 Fedora Update System 2011-06-02 08:03:02 UTC
iproute-2.6.33-9.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/iproute-2.6.33-9.fc13

Comment 8 Fedora Update System 2011-06-02 08:03:25 UTC
iproute-2.6.35-9.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/iproute-2.6.35-9.fc14

Comment 9 Fedora Update System 2011-06-03 05:26:38 UTC
Package iproute-2.6.35-9.fc14:
* should fix your issue,
* was pushed to the Fedora 14 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing iproute-2.6.35-9.fc14'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/iproute-2.6.35-9.fc14
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2011-06-15 05:36:18 UTC
iproute-2.6.35-9.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2011-06-15 05:46:00 UTC
iproute-2.6.33-9.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.