Bug 709791
| Summary: | Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ole <ole.ersoy> | ||||
| Component: | tomcat | Assignee: | Ivan Afonichev <ivan.afonichev> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | akurtako, fedora-package-review, ivan.afonichev, java-sig-commits, notting | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-06-08 11:20:50 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 502313 [details]
Patch with review modifications
The original spec defined in: https://bugzilla.redhat.com/show_bug.cgi?id=700199 Wrong component - this should have been filed against tomcat itself. Also providing a git formatted patch that the maintainer can just git am your_patch would be helpful. Looks like Ivan applied it in http://pkgs.fedoraproject.org/gitweb/?p=tomcat.git;a=commitdiff;h=ca271e5d851bea547f2020de374e685531303f18 Closing. I'm not sure that setting username to variable is a good idea tomcat6 and tomcat5 are using tomcat username httpd is using apache username... |
The bindir definition can be shortened by replacing %{_datadir}/%{name} with %{homedir} Might want to replace "tomcat" with %{name} in the add user and group block: # add the tomcat user and group %{_sbindir}/groupadd -g %{tcuid} -r tomcat 2>/dev/null || : %{_sbindir}/useradd -c "Apache Tomcat" -u %{tcuid} -g tomcat \ -s /bin/nologin -r -d %{homedir} tomcat 2>/dev/null || : In the line: %{_javadir}/%{name}/%{name}-el-%{elspec}-api.jar %{_javadir}/%{name} can be replaced with: %{libdir}?