Bug 712991

Summary: include RPM noarch in /usr/share/magic
Product: [Fedora] Fedora Reporter: James M. Leddy <james.leddy>
Component: fileAssignee: Jan Kaluža <jkaluza>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: gborsuk, jkaluza
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 712992 (view as bug list) Environment:
Last Closed: 2011-06-14 06:10:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 712992    
Attachments:
Description Flags
magic.patch
none
revised-magic.patch
none
revised-magic.patch none

Description James M. Leddy 2011-06-13 20:13:19 UTC 
Description of problem:

Hi, I would like noarch packages to have additional detail in /usr/share/magic

Version-Release number of selected component (if applicable):

file-5.07-2.fc15.x86_64

How reproducible:

Always

Steps to Reproduce:
1. file *noarch.rpm
2. See no additional arch detail
3.
  
Actual results:


$ file xguest-1.0.9-2.el6.noarch.rpm 
xguest-1.0.9-2.el6.noarch.rpm: RPM v3.0 bin


Expected results:

$ file xguest-1.0.9-2.el6.noarch.rpm 
xguest-1.0.9-2.el6.noarch.rpm: RPM v3.0 bin noarch


Additional info:

diff -c /home/james/magic\~ /home/james/magic
*** /home/james/magic~	2011-06-13 16:00:37.815627201 -0400
--- /home/james/magic	2011-06-13 16:01:08.373320151 -0400
***************
*** 14784,14789 ****
--- 14784,14790 ----
  >>>8	beshort		16		PowerPC64
  >>>8	beshort		17		SuperH
  >>>8	beshort		18		Xtensa
+ >>>8    beshort         255             noarch
  
  #delta RPM    Daniel Novotny (dnovotny)
  0	string	drpm	Delta RPM

Diff finished.  Mon Jun 13 16:09:30 2011
Comment 1 James M. Leddy 2011-06-13 20:13:51 UTC 
Created attachment 504536 [details]
magic.patch
Comment 2 James M. Leddy 2011-06-13 22:47:11 UTC 
Created attachment 504563 [details]
revised-magic.patch

This is actually not sufficient. There are some packages, for example, asterisk-sounds-core-fr-sln16-1.4.20-1.el6.noarch.rpm, that identify as something other than RPM. The easiest solution is to just have the first 8 bytes match as in this patch.
Comment 3 James M. Leddy 2011-06-13 22:51:04 UTC 
Created attachment 504564 [details]
revised-magic.patch