| Summary: | Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Khusro Jaleel <kerneljack> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, me, notting, paul |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-05 18:25:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Khusro Jaleel
2011-06-19 04:11:51 UTC
I inspected the spec file, and it seems to match the guidelines listed: http://fedoraproject.org/wiki/Simple_fonts_spec_template it also passed rpmlint cleanly. I would recommend publishing a koji scratch build. I'd be happy to review this package and look at sponsoring you. ;) Look for a full review hopefully later today. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (OFL) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 72b228695f1ad8ac0e3824a1e7edb313 league-gothic.zip 72b228695f1ad8ac0e3824a1e7edb313 ../SOURCES/league-gothic.zip OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Not a blocker, but you might add to the description. Reading just what you have makes it sound like this is a public domain font from 1903, but in fact the second paragraph upstream says: "We decided to make our own version, and contribute it to the Open Source Type Movement. It’s free, not only in price, but in freedom" So, perhaps a note that this is a version of that font? 2. Might ask upstream if they could include a copy of the OFL in their zip file? (Not a blocker, but nice to have). 3. rpmlint says: tlomt-league-gothic-fonts.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Which can be ignored. Fix up the description and I think we are good to go... Thanks, Kevin. I have updated the description field now and uploaded a new .src.rpm with an incremented Release tag of "2". You will find it below: SRPM: http://kerneljack.com/rpms/tlomt-league-gothic-fonts-1.0-2.fc15.src.rpm SPEC: http://kerneljack.com/rpms/tlomt-league-gothic-fonts.spec Koji scratch build against Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=3176288 Please let me know if this is ok, thanks again for the help. I'm going to package up another font soon! Looks good. This package is APPROVED. I will go ahead and sponsor you. Can you confirm your fedora account system account name for me in email or irc (my nick on irc is 'nirik') ? Please don't hesitate to ask questions and I will assist you as best I can. After I sponsor you in the account system you can continue the process from: https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner Please complete a SCM request if setting the fedora-cvs flag. New Package SCM Request ======================= Package Name: tlomt-league-gothic-fonts Short Description: League Gothic is a revival of an old classic, Alternate Gothic No.1. Owners: kjaleel Branches: f14 f15 el5 el6 InitialCC: fonts-sig Git done (by process-git-requests). Khusro, could you please complete some builds of this and push them as updates so this review gets closed off? Hi Paul, apologies for the late reply here, I was hoping to find some time to re-read the package review guidelines document to find out what I was missing before asking you, but I haven't had much time to do so. As far as I was aware, I have already created the package and done a koji build, etc and the package is now part of F16, so I am not sure what is left remaining to be done? Could you please let me know? Thanks. OK, I can see the build for F16, but Bodhi isn't showing any updates. Closing now. |