Bug 714702

Summary:	Legacy SysV initscript file must go into an optional subpackage.
Product:	[Fedora] Fedora	Reporter:	Jóhann B. Guðmundsson <johannbg>
Component:	NetworkManager	Assignee:	Dan Williams <dcbw>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dcbw, mads, orion
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	NetworkManager-0.9.0-2.fc16	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-09-30 19:45:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	713562

Description Jóhann B. Guðmundsson 2011-06-20 13:26:57 UTC

Description of problem:

Currently your component is providing both native systemd service files and
legacy sysv init script in the same package which is in violation of the
packaging guidelines[1]. 

Once a native systemd service file is shipped and if the intention is to
continue to maintain and ship the old sysv initscript the old sysvinit must go
into an optional subpackage.

"SysV Initscripts
Packages may also provide a SysV initscript file, but are not required to do
so. This format is considered legacy, but Fedora still contains init mechanisms
such as upstart which do not support the systemd unit file format. If present,
the SysV initscript(s) must go into an optional subpackage, so as not to
confuse sysadmins. The guidelines for SysV initscripts can be found here:
Packaging:SysVInitScript"

1.http://fedoraproject.org/wiki/Packaging:Guidelines:Systemd

Version-Release number of selected component (if applicable):

NetworkManager-1:0.8.9997-1.git20110531.fc16.x86_64.rpm

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jóhann B. Guðmundsson 2011-07-15 15:09:14 UTC

What's the current status of you are one of few that is not package
native systemd unit in the Base group correctly?

If you dont have the time to fix this should I try to find a proven packager to
do the work for you? 

https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
https://fedoraproject.org/wiki/Packaging:Tmpfiles.d

Comment 2 Dan Williams 2011-07-19 03:16:30 UTC

I've elected to disable the sysv initscript when systemd is enabled.  That change has been made upstream as 530f2674d48d100e42c83ea414dc877ad4b55ee9, so this bug can be closed when that fix rolls out.  As systemd is an integral part of the Fedora system, there's not much point in having a sysv initscript for NM too.

Comment 3 Dan Williams 2011-07-19 03:17:29 UTC

*** Bug 697524 has been marked as a duplicate of this bug. ***

Comment 4 Mads Kiilerich 2011-08-10 07:58:54 UTC

I assume this is included in NetworkManager-0.8.9997-7.git20110721.fc16.i686 in f16 which doesn't have /etc/rc.d/init.d/NetworkManager? 

However, that causes failure on installation (when building livecd):
  Installing: NetworkManager               ##################### [489/616]error reading information on service NetworkManager: No such file or directory
error reading information on service NetworkManager: No such file or directory

The chkconfig invocations in the %post script should be removed too.

Comment 5 Orion Poplawski 2011-08-31 16:01:34 UTC

The %post error is still in NetworkManager-0.9.0-1.fc16.

Comment 6 Fedora Update System 2011-09-09 18:43:24 UTC

NetworkManager-0.9.0-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/NetworkManager-0.9.0-2.fc16

Comment 7 Fedora Update System 2011-09-10 18:57:50 UTC

Package NetworkManager-0.9.0-2.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing NetworkManager-0.9.0-2.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/NetworkManager-0.9.0-2.fc16
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2011-09-30 19:45:30 UTC

NetworkManager-0.9.0-2.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.