Bug 715286

Summary: Fix inconsistent permissions fixing on /var/cache/mock in SPEC template
Product: [Fedora] Fedora Reporter: Yury V. Zaytsev <yury>
Component: mockAssignee: Clark Williams <williams>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: mebrown, williams
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: mock-1.1.15-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-02 23:01:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Trivial fix
none
Additional fix
none
Yet another bug in the SPEC, this time /var/{lib,cache}/permissions were not set correctly in the files section none

Description Yury V. Zaytsev 2011-06-22 12:41:10 UTC
Actual results:

/var/cache/mock is declared 2775 in setup, then overridden in postinstall

Expected results:

/var/cache/mock should be 2775 everywhere

Additional info:

Please see patch attached.

Comment 1 Yury V. Zaytsev 2011-06-22 12:43:46 UTC
Created attachment 505994 [details]
Trivial fix

Comment 2 Yury V. Zaytsev 2011-06-22 13:03:09 UTC
Created attachment 505999 [details]
Additional fix

Additionally, it does not make sense to set /var/cache/mock to 2775 upon %install because it's done in %files anyway. Needless duplication clutters the SPEC and makes it harder to maintain.

Comment 3 Clark Williams 2011-06-22 14:09:09 UTC
Thanks, I've added your patches (I combined the two into one git commit) for the next release.

Comment 4 Yury V. Zaytsev 2011-06-23 12:28:16 UTC
Created attachment 506226 [details]
Yet another bug in the SPEC, this time /var/{lib,cache}/permissions were not set correctly in the files section

Hi!

You are quite welcome; thanks for the prompt reaction. There seems to be yet another bug, however. The %attr macro as used in the SPEC only applies to *files*, not *directories*, thus the permissions were not being set correctly on the lib folder (not sure how important is that).

This bug would surface with the cache directory if one day the fix from %post will be removed and it hit me already on a clean install.

Thanks!

Comment 5 Yury V. Zaytsev 2011-06-23 12:32:22 UTC
Additionally, as I noted in an e-mail, it would be nice to have the tarballs updated on the FedoraHosted page. I can do this for you, but I need an account :-/

Comment 6 Yury V. Zaytsev 2011-09-21 17:28:23 UTC
The last patch (attachment 506226 [details]) is still relevant.

Comment 7 Clark Williams 2011-09-23 18:58:37 UTC
Ok, queued for the 1.1.15 release

Comment 8 Fedora Update System 2011-09-23 20:55:27 UTC
mock-1.1.15-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/mock-1.1.15-1.fc15

Comment 9 Fedora Update System 2011-09-23 20:56:29 UTC
mock-1.1.15-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/mock-1.1.15-1.el6

Comment 10 Fedora Update System 2011-09-23 20:57:23 UTC
mock-1.0.22-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/mock-1.0.22-1.el5

Comment 11 Fedora Update System 2011-09-23 20:58:13 UTC
mock-1.1.15-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/mock-1.1.15-1.fc14

Comment 12 Fedora Update System 2011-09-24 21:59:40 UTC
Package mock-1.1.15-1.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing mock-1.1.15-1.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/mock-1.1.15-1.el6
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2011-10-02 22:59:58 UTC
mock-1.1.15-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2011-10-02 23:08:24 UTC
mock-1.1.15-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2011-10-16 18:27:58 UTC
mock-1.0.22-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2011-10-16 18:29:45 UTC
mock-1.1.15-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.