Bug 716610 (ghc-monad-peel)

Summary:	Review Request: ghc-monad-peel - A library to lift control in monad transformers
Product:	[Fedora] Fedora	Reporter:	Narasimhan <lakshminaras2002>
Component:	Package Review	Assignee:	Ben Boeckel <fedora>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fedora, fedora-package-review, haskell-devel, notting
Target Milestone:	---	Flags:	fedora: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-11-28 11:54:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	662481

Description Narasimhan 2011-06-25 13:23:04 UTC

spec file : http://narasim.fedorapeople.org/package_reviews/ghc-monad-peel.spec

srpm file : http://narasim.fedorapeople.org/package_reviews/ghc-monad-peel-0.1-1.fc15.src.rpm

rpmlint output:
 rpmlint -i ghc-monad-peel.spec ~/rpmbuild/RPMS/x86_64/ghc-monad-peel-*.rpm ~/rpmbuild/SRPMS/ghc-monad-peel-0.1-1.fc15.src.rpm 
ghc-monad-peel.x86_64: W: spelling-error %description -l en_US monads -> nomads, gonads
The value of this tag appears to be misspelled. Please double-check.

ghc-monad-peel-devel.x86_64: W: spelling-error %description -l en_US monads -> nomads, gonads
The value of this tag appears to be misspelled. Please double-check.

ghc-monad-peel.src: W: spelling-error %description -l en_US monads -> nomads, gonads
The value of this tag appears to be misspelled. Please double-check.

3 packages and 1 specfiles checked; 0 errors, 3 warnings.

Comment 1 Narasimhan 2011-06-25 13:24:28 UTC

http://koji.fedoraproject.org/koji/taskinfo?taskID=3160457

Comment 2 Ben Boeckel 2011-07-26 02:33:40 UTC

I'll take this.

Initial impressions:

 - Remove '@' characters from the %common_description.
 - Update to cabal2spec-0.24

Comment 3 Narasimhan 2011-07-31 04:27:39 UTC

Spec file link:
http://narasim.fedorapeople.org/package_reviews/ghc-monad-peel.spec

SRPM link
http://narasim.fedorapeople.org/package_reviews/ghc-monad-peel-0.1-1.fc15.src.rpm

rpmlint  -i ~/rpmbuild/RPMS/i686/ghc-monad-peel-devel-0.1-2.fc14.i686.rpm ~/rpmbuild/RPMS/i686/ghc-monad-peel-0.1-2.fc14.i686.rpm ~/rpmbuild/SRPMS/ghc-monad-peel-0.1-2.fc14.src.rpm ghc-monad-peel.spec
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

cabal2spec 0.24 is not available for f14,f15. I made a local build, then installed and used it.

Comment 4 Jens Petersen 2011-11-23 12:39:49 UTC

Is this still needed?

http://packdeps.haskellers.com/reverse/monad-peel

Comment 5 Narasimhan 2011-11-28 11:54:22 UTC

Can be closed I guess.