Bug 716984

Summary: Legacy SysV initscript file must go into an optional subpackage.
Product: [Fedora] Fedora Reporter: Jóhann B. Guðmundsson <johannbg>
Component: gpmAssignee: Nikola Pajkovsky <npajkovs>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dhoward, npajkovs, pertusus
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gpm-1.20.6-18.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-23 20:28:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 713562    
Attachments:
Description Flags
Spec file patch for gpm none

Description Jóhann B. Guðmundsson 2011-06-27 16:38:05 UTC 
Description of problem:

Currently your component is providing both native systemd service files and
legacy sysv init script in the same package which is in violation of the
packaging guidelines[1]. 

Once a native systemd service file is shipped and if the intention is to
continue to maintain and ship the old sysv initscript the old sysvinit  must go
into an optional subpackage.

"SysV Initscripts
Packages may also provide a SysV initscript file, but are not required to do
so. This format is considered legacy, but Fedora still contains init mechanisms
such as upstart which do not support the systemd unit file format. If present,
the SysV initscript(s) must go into an optional subpackage, so as not to
confuse sysadmins. The guidelines for SysV initscripts can be found here:
Packaging:SysVInitScript"

http://fedoraproject.org/wiki/Packaging:Guidelines:Systemd
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
http://fedoraproject.org/wiki/Packaging:Tmpfiles.d


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Jóhann B. Guðmundsson 2011-07-15 15:01:22 UTC 
What's the current status of you are one of few that is not package
native systemd unit in the Base group correctly?

If you dont have the time to fix this should I try to find a proven packager to
do the work for you? 

https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
https://fedoraproject.org/wiki/Packaging:Tmpfiles.d
Comment 2 Jóhann B. Guðmundsson 2011-07-26 22:35:43 UTC 
Created attachment 515381 [details]
Spec file patch for gpm

Note this has to be cleanup before thursday
Comment 3 Nikola Pajkovsky 2011-08-05 09:10:54 UTC 
thanks for patch, I really appreciate it!

Honestly, your patch is not applicable, because
1)
--- file_not_specified_in_diff	
+++ file_not_specified_in_diff

I know that this is a diff between spec file, but '$ patch' does not

2)
you are in git man! '$ git commit -sm "message"' and '$ git format-patch -1' will do a great job for you ;)
Comment 4 Fedora Update System 2011-08-05 12:22:57 UTC 
gpm-1.20.6-18.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/gpm-1.20.6-18.fc16
Comment 5 Fedora Update System 2011-08-05 20:07:50 UTC 
Package gpm-1.20.6-18.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gpm-1.20.6-18.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/gpm-1.20.6-18.fc16
then log in and leave karma (feedback).
Comment 6 Fedora Update System 2011-08-23 20:28:45 UTC 
gpm-1.20.6-18.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.