Bug 718039

Summary: Fix naming of classes in wrapper and maven pom.xml
Product: [Fedora] Fedora Reporter: Felix Kaechele <felix>
Component: checkstyleAssignee: Stanislav Ochotnicky <sochotni>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dbhole, sochotni
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-01 09:42:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Jakarta -> Apache Rename in Wrapper
none
google-collection -> guava rename none

Description Felix Kaechele 2011-06-30 19:11:32 UTC 
Description of problem:

1. google-collection has been renamed to guava
   needs to be changed in pom.xml accordingly

2. The jakarta to apache rename needs to be done in the checkstyle wrapper script as well.

Patches against a "fedpkg clone checkstyle" git repo are attached
Comment 1 Felix Kaechele 2011-06-30 19:12:17 UTC 
Created attachment 510739 [details]
Jakarta -> Apache Rename in Wrapper
Comment 2 Felix Kaechele 2011-06-30 19:12:46 UTC 
Created attachment 510740 [details]
google-collection -> guava rename
Comment 3 Stanislav Ochotnicky 2011-07-01 09:42:46 UTC 
http://koji.fedoraproject.org/koji/buildinfo?buildID=251210

If fixed the script (in a different way so I didn't use your patch). Plus I fixed a few more problems.

As for the pom dependency on google-collections, if you checkout guava in Fedora you will see it has two calls:

%add_to_maven_depmap com.google.guava %{name} %{version} JPP %{name}
%add_to_maven_depmap com.google.collections google-collections 1.0 JPP %{name}

This tells our maven that both group/artifact ids point to same jar file and thus for us this is not a problem. It should be reported upstream though so that they can use up-to-date artifacts. You want to do it or should I?

Thanks for the bugreport and patches!