Bug 718039 - Fix naming of classes in wrapper and maven pom.xml
Summary: Fix naming of classes in wrapper and maven pom.xml
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: checkstyle
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-30 19:11 UTC by Felix Kaechele
Modified: 2011-07-01 09:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-01 09:42:46 UTC
Type: ---


Attachments (Terms of Use)
Jakarta -> Apache Rename in Wrapper (1004 bytes, patch)
2011-06-30 19:12 UTC, Felix Kaechele
no flags Details | Diff
google-collection -> guava rename (2.96 KB, patch)
2011-06-30 19:12 UTC, Felix Kaechele
no flags Details | Diff

Description Felix Kaechele 2011-06-30 19:11:32 UTC
Description of problem:

1. google-collection has been renamed to guava
   needs to be changed in pom.xml accordingly

2. The jakarta to apache rename needs to be done in the checkstyle wrapper script as well.

Patches against a "fedpkg clone checkstyle" git repo are attached

Comment 1 Felix Kaechele 2011-06-30 19:12:17 UTC
Created attachment 510739 [details]
Jakarta -> Apache Rename in Wrapper

Comment 2 Felix Kaechele 2011-06-30 19:12:46 UTC
Created attachment 510740 [details]
google-collection -> guava rename

Comment 3 Stanislav Ochotnicky 2011-07-01 09:42:46 UTC
http://koji.fedoraproject.org/koji/buildinfo?buildID=251210

If fixed the script (in a different way so I didn't use your patch). Plus I fixed a few more problems.

As for the pom dependency on google-collections, if you checkout guava in Fedora you will see it has two calls:

%add_to_maven_depmap com.google.guava %{name} %{version} JPP %{name}
%add_to_maven_depmap com.google.collections google-collections 1.0 JPP %{name}

This tells our maven that both group/artifact ids point to same jar file and thus for us this is not a problem. It should be reported upstream though so that they can use up-to-date artifacts. You want to do it or should I?

Thanks for the bugreport and patches!


Note You need to log in before you can comment on or make changes to this bug.