| Summary: | Review Request: libmusicbrainz4-4.0.0 - Library for accessing MusicBrainz servers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Upstream Release Monitoring <upstream-release-monitoring> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ccecchi, cfergeau, ismael, notting, package-review, rdieter |
| Target Milestone: | --- | Keywords: | FutureFeature, Triaged |
| Target Release: | --- | Flags: | ccecchi:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libmusicbrainz4-4.0.0-1.fc16 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-06 22:27:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Upstream Release Monitoring
2011-07-02 10:31:56 UTC
Fwiw, this is a new library with a new API and new ABI, so it probably belongs to a libmusicbrain4-4.0 package rather than libmusicbrainz3-4.0 Latest upstream release: 4.0.0beta2 Current version in Fedora Rawhide: 3.0.3 URL: http://musicbrainz.org/doc/libmusicbrainz Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring libmusicbrainz 4.0.0 has been released: http://blog.musicbrainz.org/?p=1259 Latest upstream release: 4.0.0 Current version in Fedora Rawhide: 3.0.3 URL: http://musicbrainz.org/doc/libmusicbrainz Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring Spec URL: http://teuf.fedorapeople.org/reviews/libmusicbrainz4/libmusicbrainz4.spec SRPM URL:http://teuf.fedorapeople.org/reviews/libmusicbrainz4/libmusicbrainz4-4.0.0-1.fc18.src.rpm Description: The MusicBrainz client library allows applications to make metadata lookup to a MusicBrainz server, generate signatures from WAV data and create CD Index Disk ids from audio CD roms. Okay, giving a shot at this - it's my first package review, so apologies if I am missing something.
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name. - OK
- Spec has consistent macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - LGPLv2+ (OK)
- License field in spec matches - OK
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum: - OK
21c33f5dd20b8bb945b800e2a964f27e libmusicbrainz-4.0.0.tar.gz
- Package needs ExcludeArch - N/A
- BuildRequires correct - OK
- Spec handles locales/find_lang - N/A
- Package is code or permissible content. - OK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK
- Headers/static libs in -devel subpackage. - OK
- Spec has needed ldconfig in post and postun - OK
- .pc files in -devel subpackage/requires pkgconfig - ***
-devel subpackage is missing a requires on pkgconfig
- .so files in -devel subpackage. - OK
- -devel package Requires: %{name} = %{version}-%{release} -OK
- .la files are removed. - ***
They don't seem to be removed, but maybe it's not necessary here?
- Package is a GUI app and has a .desktop file - N/A
- Package compiles and builds on at least one arch. - tested x86_64 w/mock
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. -OK
- Package owns all the directories it creates. - OK
- No rpmlint output. - ***
libmusicbrainz4.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libmusicbrainz4.src: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up
libmusicbrainz4.src: W: spelling-error %description -l en_US roms -> toms, rims, oms
- final provides and requires are sane: OK
SHOULD Items:
- Should build in mock. - tested x86_64
- Should build on all supported archs - didn't test
- Should function as described. - didn't test
- Should have sane scriptlets. - OK
- Should have subpackages require base package with fully versioned depend. -
OK
- Should have dist tag - OK
- Should package latest version - OK
Issues:
- Add pkgconfig to Requires in -devel
- Check whether it's required to remove .la files
(In reply to comment #6) > Issues: > - Add pkgconfig to Requires in -devel > - Check whether it's required to remove .la files It's using cmake and doesn't seem to be using libtool, I checked with http://koji.fedoraproject.org/koji/taskinfo?taskID=3858699 that the built rpms don't have .la files. As for the pkgconfig Requires, the -devel already got a dependency on /usr/bin/pkgconfig (my guess is that rpmbuild adds this automatically to packages containing a .pc file). Do I need to add an explicit Requires: anyway? Explicit pkgconfig dependency is not required (rpm autogenerates deps as needed these days) Looks good to me then. Approved. New Package SCM Request ======================= Package Name: libmusicbrainz4 Short Description: Library for accessing MusicBrainz servers Owners: teuf rdieter Branches: f16 f17 InitialCC: Rex, I added you as a secondary owner of this package since you already maintain libmusicbrainz3, I hope this is fine with you :) Git done (by process-git-requests). Submitter, please leave version numbers out of the subject. Reviewer, please take ownership of review BZs. Thanks! libmusicbrainz4-4.0.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libmusicbrainz4-4.0.0-1.fc17 libmusicbrainz4-4.0.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libmusicbrainz4-4.0.0-1.fc16 libmusicbrainz4-4.0.0-1.fc17 has been pushed to the Fedora 17 stable repository. *** Bug 802962 has been marked as a duplicate of this bug. *** libmusicbrainz4-4.0.0-1.fc16 has been pushed to the Fedora 16 stable repository. |