Bug 719323 (libkipi)
| Summary: | Review Request: libkipi - Common plugin infrastructure for KDE image applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | nucleo <alekcejk> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alekcejk, gwync, marcus, notting, package-review |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | alekcejk:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-11 17:43:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 719328, 719342 | ||
|
Description
Rex Dieter
2011-07-06 13:49:13 UTC
Almost all sources in libkipi GPLv2+ and only libkipi_export.h have LGPLv2+ license so resulting license maybe is GPLv2+? scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3182848 rpmlint output: libkipi.i686: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.i686: E: zero-length /usr/share/doc/libkipi-4.6.90/TODO libkipi.src: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.90/src/libkipi-4.6.90.tar.bz2 <urlopen error ftp error: 550 Failed to change directory.> libkipi.x86_64: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.x86_64: E: zero-length /usr/share/doc/libkipi-4.6.90/TODO libkipi-devel.i686: W: no-documentation libkipi-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 2 errors, 6 warnings. TODO file is empty (NEWS can be added instead it). invalid-url error because 4.6.90 is in unstable dir. Is update-desktop-database really needed? kipiplugin.desktop installed in /usr/share/kde4/servicetypes but update-desktop-database searches files in /usr/share/applications. nope, it's not needed, thanks. I'll fix up those issues, and upload a new one here shortly. Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkipi.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkipi-4.6.90-2.fc15.src.rpm %changelog * Wed Jul 06 2011 Rex Dieter <rdieter> 4.6.90-2 - License: GPLv2+ - fix scriptlets - %%doc: +NEWS, -TODO and %changelog - fix URL rpmlint output for libkipi-4.6.90-3* rpms and -debuginfo: libkipi.i686: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.src: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.x86_64: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi-devel.i686: W: no-documentation libkipi-devel.x86_64: W: no-documentation So all issues fixed now.
Package and spec names are fine,
license GPLv2+ is actual license used in libkipi sources,
Requires in devel packages is %{name}%{?_isa} = %{version}-%{release},
scriptlets are fine.
Package APPROVED
Is this package will be built after all other packages from kdegraphics will be ready? Wrt when to build this, we'll probably wait until the stack up through okular is reviewed first. Imported (using prior/old libkipi module from kde3 era...) Looks like this is deprecated in pkgdb, we'll need intervention. Package Change Request ====================== Package Name: libkipi Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix It is will be better to change URL to https://projects.kde.org/projects/kde/kdegraphics/libs/libkipi Sorry that I not noticed this before. Misformed request, what sort of intervention are you referring to? Package Change Request ====================== Package Name: libkipi Short Description: Common plugin infrastructure for KDE image applications Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15 3 things needed: 1. updated owners 2. f15 branch 3. mark package not deprecated in pkgdb Git done (by process-git-requests). Created f15 branch, I can't do 1 or 3, you'll need to file a rel-eng trac. Ok, thanks! Not sure if this is where I should report this, but on my Fedora 22 system, running "dnf remove libkipi" results in the error, "The operation would result in removing the following protected packages: systemd." |