Bug 719731

*** Bug 719999 has been marked as a duplicate of this bug. ***

side note: looks like copy-paste error with the message. this doesn't have to do with connection settings, its reosurce config. I'm gonna change the four places where that exception message was. For the two that involve resource configuration, it will say:

"The server did not return the configuration for one or more member resources."

For the two that involve connection properties (aka plugin configuration), it will say:

"The server did not return the connection settings for one or more member resources."

I see this in the server log, looks related:

13:28:15,437 ERROR [ConfigurationManagerBean] Current Configuration for Resource[id=10364, type=RHQ Agent, key=agent2 RHQ Agent, name=RHQ Agent, parent=agent2, version=4.1.0-SNAPSHOT] does not match latest associated ResourceConfigurationUpdate with SUCCESS status.

From the GWT error message and this log error message, it appears that the server is rejecting the live config because it doesn't match what's in our DB. Thus, it is probably not sending that to the client hence why the client is saying it didn't get one or more configs for a member resource

Here is the relevant code in ConfigurationManagerBean. We check to see if the live configs match the latest SUCCESS configs - if they don't, we persist them into the audit history and use it. For some reason, persistNewAgentReportedResourceConfiguration is returning null:

        // If we got this far, we were able to retrieve all of the live configs from the Agents. Now load the current
        // persisted configs from the DB and compare them to the corresponding live configs. For any that are not equal,
        // persist the live config to the DB as the new current config.
        Map<Integer, Configuration> currentPersistedConfigs = getPersistedResourceConfigurationsForCompatibleGroup(group);
        for (Resource memberResource : groupMembers) {
            Configuration liveConfig = liveConfigs.get(memberResource.getId());
            // NOTE: The persisted config may be null if no config has been persisted yet.
            Configuration currentPersistedConfig = currentPersistedConfigs.get(memberResource.getId());
            if (!liveConfig.equals(currentPersistedConfig)) {
                // If the live config is different than the persisted config, persist it as the new current config.
                ResourceConfigurationUpdate update = persistNewAgentReportedResourceConfiguration(memberResource,
                    liveConfig);
                if (update != null)
                    currentPersistedConfigs.put(memberResource.getId(), update.getConfiguration());
                else
                    log.error("Current Configuration for " + memberResource
                        + " does not match latest associated ResourceConfigurationUpdate with SUCCESS status.");
            }
        }

I think the problem is that the return value of persistNewAgentReportedResourceConfiguration was not properly understood. If it returns null, it means the live config is the same as the persisted config. But that null value was ignored and we never even stored the live config in the returned map.

master commit a7d37237828a22d5ab19cc4ec63f28a5f9ef0083

Verified on build#298 (Version: 4.1.0-SNAPSHOT Build Number: 66918cb)

Created a compatible group of one RHQ Agent. Navigated to the configuration tab of the resource. The configuration details are displayed and no exception is observed. Also verified with adding one more RHQ Agent resource of another platform to the compatible group and navigating to the configuration tab of the group.

Marking as verified.

marking VERIFIED BZs to CLOSED/CURRENTRELEASE

changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE