| Summary: | Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Lalancette <clalance> |
| Component: | Package Review | Assignee: | Mo Morsi <mmorsi> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mmorsi, notting, package-review |
| Target Milestone: | --- | Flags: | mmorsi:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-20 17:36:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Chris Lalancette
2011-07-08 15:06:40 UTC
Taking this one Overall looks good. Koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3199631 Specific notes: - the requires rubygem(rake) and rubygem(rspec) should be changed to buildrequires. Since the gem ships w/ a spec suite, it should be invoked in a %check section - need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby - include a "--ri" flag in the gem install command - rpmlint complains about the following hidden files which should be removed: .yardopts, .gitignore, .infinity_test (not sure what the last one is and/or if it's needed) - the following files should be marked as %doc in the %files section: spec/ directory, license, readme, rakefile, chunky_png.gemspec, benchmarks - consider dropping the "also have a look at oilypng..." blurb from the package description (In reply to comment #2) > Overall looks good. Koji build is green: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=3199631 > > Specific notes: > > - the requires rubygem(rake) and rubygem(rspec) should be changed to > buildrequires. Since the gem ships w/ a spec suite, it should be invoked in a > %check section I tried doing this, but I haven't been able to successfully run the test suite. I'm not sure if the version of rspec is too old, or what, but it always fails to load some files. I've removed the two buildrequires for now, and we can revisit it later on. > > - need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby Fixed. > > - include a "--ri" flag in the gem install command Fixed. > > - rpmlint complains about the following hidden files which should be removed: > .yardopts, .gitignore, .infinity_test (not sure what the last one is and/or if > it's needed) Removed. > > - the following files should be marked as %doc in the %files section: spec/ > directory, license, readme, rakefile, chunky_png.gemspec, benchmarks Fixed. > > - consider dropping the "also have a look at oilypng..." blurb from the package > description Removed. New SRPM: http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png-1.2.0-2.fc14.src.rpm New SPEC: http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png.spec Looks good. APPROVED. New Package SCM Request ======================= Package Name: rubygem-chunky_png Short Description: Pure ruby library for read/write, chunk-level access to PNG files Owners: clalance mmorsi Git done (by process-git-requests). |