Hide Forgot
Spec URL: http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png.spec SRPM URL: http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png-1.2.0-1.fc14.src.rpm Description: This pure Ruby library can read and write PNG images without depending on an external image library, like RMagick. It tries to be memory efficient and reasonably fast. It supports reading and writing all PNG variants that are defined in the specification, with one limitation: only 8-bit color depth is supported. It supports all transparency, interlacing and filtering options the PNG specifications allows. It can also read and write textual metadata from PNG files. Low-level read/write access to PNG chunks is also possible. This library supports simple drawing on the image canvas and simple operations like alpha composition and cropping. Finally, it can import from and export to RMagick for interoperability. Also, have a look at OilyPNG at http://github.com/wvanbergen/oily_png. OilyPNG is a drop in mixin module that implements some of the ChunkyPNG algorithms in C, which provides a massive speed boost to encoding and decoding. [clalance@localhost SPECS]$ rpmlint rubygem-chunky_png.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [clalance@localhost SPECS]$ rpmlint ../SRPMS/rubygem-chunky_png-1.2.0-1.fc14.src.rpm rubygem-chunky_png.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsus rubygem-chunky_png.src: W: spelling-error %description -l en_US mixin -> mixing, mirin, mix in 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Taking this one
Overall looks good. Koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3199631 Specific notes: - the requires rubygem(rake) and rubygem(rspec) should be changed to buildrequires. Since the gem ships w/ a spec suite, it should be invoked in a %check section - need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby - include a "--ri" flag in the gem install command - rpmlint complains about the following hidden files which should be removed: .yardopts, .gitignore, .infinity_test (not sure what the last one is and/or if it's needed) - the following files should be marked as %doc in the %files section: spec/ directory, license, readme, rakefile, chunky_png.gemspec, benchmarks - consider dropping the "also have a look at oilypng..." blurb from the package description
(In reply to comment #2) > Overall looks good. Koji build is green: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=3199631 > > Specific notes: > > - the requires rubygem(rake) and rubygem(rspec) should be changed to > buildrequires. Since the gem ships w/ a spec suite, it should be invoked in a > %check section I tried doing this, but I haven't been able to successfully run the test suite. I'm not sure if the version of rspec is too old, or what, but it always fails to load some files. I've removed the two buildrequires for now, and we can revisit it later on. > > - need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby Fixed. > > - include a "--ri" flag in the gem install command Fixed. > > - rpmlint complains about the following hidden files which should be removed: > .yardopts, .gitignore, .infinity_test (not sure what the last one is and/or if > it's needed) Removed. > > - the following files should be marked as %doc in the %files section: spec/ > directory, license, readme, rakefile, chunky_png.gemspec, benchmarks Fixed. > > - consider dropping the "also have a look at oilypng..." blurb from the package > description Removed. New SRPM: http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png-1.2.0-2.fc14.src.rpm New SPEC: http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png.spec
Looks good. APPROVED.
New Package SCM Request ======================= Package Name: rubygem-chunky_png Short Description: Pure ruby library for read/write, chunk-level access to PNG files Owners: clalance mmorsi
Git done (by process-git-requests).