Bug 720730

Summary: Resource leaks revealed by Coverity scan
Product: Red Hat Enterprise Linux 6 Reporter: Michal Luscon <mluscon>
Component: lldpadAssignee: Petr Šabata <psabata>
Status: CLOSED ERRATA QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: low    
Version: 6.1CC: azelinka, ovasik, praiskup, psklenar
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: lldpad-0.9.43-3.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 14:40:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
get_bcn() resource leak patch none

Description Michal Luscon 2011-07-12 15:53:30 UTC 
Description of problem:

lldpad-0.9.41/nltest.c:785,791,874 - Function get_bcn returns without freeing variable nhl. 

Version-Release number of selected component (if applicable):
0.9.41-4

Additional info:
These defects were probably introduced by Red Hat patches.
Comment 2 Petr Šabata 2011-08-08 13:18:46 UTC 
Created attachment 517208 [details]
get_bcn() resource leak patch

A possible patch fixing the described defect.
Comment 4 Petr Šabata 2011-08-15 07:18:12 UTC 
Patch applied in CVS, lldpad-0.9.43-3.el6.
Comment 7 Pavel Raiskup 2011-10-27 12:41:48 UTC 
I hope this bug was about Red Hat patches and mentioned error was successfully removed already in lldpad-0.9.43-3.el6 and is not present even in lldpad-0.9.43-10.el6:

http://releng-test1.englab.brq.redhat.com/covscan/task/209/

So it looks it could be switched to VERIFIED now. 

--- 

As you can see from new log, there are lot of similar resource leaks in original source in nltest.c. If this should be really repaired, we could rather clone this bug for RHEL 6.3 or maybe consult it with upstream but it is not going to be about this #720730. Moreover it looks that this source is not for regular use (maybe for testing reasons?..) so switching to verified should be good enough.
Comment 9 errata-xmlrpc 2011-12-06 14:40:13 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1604.html