Bug 720730 - Resource leaks revealed by Coverity scan
Summary: Resource leaks revealed by Coverity scan
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: lldpad
Version: 6.1
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: rc
: ---
Assignee: Petr Šabata
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-12 15:53 UTC by Michal Luscon
Modified: 2011-12-06 14:40 UTC (History)
4 users (show)

Fixed In Version: lldpad-0.9.43-3.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-06 14:40:13 UTC
Target Upstream Version:


Attachments (Terms of Use)
get_bcn() resource leak patch (927 bytes, patch)
2011-08-08 13:18 UTC, Petr Šabata
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1604 0 normal SHIPPED_LIVE lldpad bug fix and enhancement update 2011-12-06 00:51:11 UTC

Description Michal Luscon 2011-07-12 15:53:30 UTC
Description of problem:

lldpad-0.9.41/nltest.c:785,791,874 - Function get_bcn returns without freeing variable nhl. 

Version-Release number of selected component (if applicable):
0.9.41-4

Additional info:
These defects were probably introduced by Red Hat patches.

Comment 2 Petr Šabata 2011-08-08 13:18:46 UTC
Created attachment 517208 [details]
get_bcn() resource leak patch

A possible patch fixing the described defect.

Comment 4 Petr Šabata 2011-08-15 07:18:12 UTC
Patch applied in CVS, lldpad-0.9.43-3.el6.

Comment 7 Pavel Raiskup 2011-10-27 12:41:48 UTC
I hope this bug was about Red Hat patches and mentioned error was successfully removed already in lldpad-0.9.43-3.el6 and is not present even in lldpad-0.9.43-10.el6:

http://releng-test1.englab.brq.redhat.com/covscan/task/209/

So it looks it could be switched to VERIFIED now. 

--- 

As you can see from new log, there are lot of similar resource leaks in original source in nltest.c. If this should be really repaired, we could rather clone this bug for RHEL 6.3 or maybe consult it with upstream but it is not going to be about this #720730. Moreover it looks that this source is not for regular use (maybe for testing reasons?..) so switching to verified should be good enough.

Comment 9 errata-xmlrpc 2011-12-06 14:40:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1604.html


Note You need to log in before you can comment on or make changes to this bug.