Bug 720806

Summary: Popen.kill is python >= 2.6
Product: [Retired] Grinder Reporter: Chris St. Pierre <cstpierr>
Component: coreAssignee: Jeff Ortel <jortel>
Status: CLOSED EOL QA Contact: Preethi Thomas <pthomas>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: jortel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch to fix the bug none

Description Chris St. Pierre 2011-07-12 19:52:25 UTC
Created attachment 512508 [details]
patch to fix the bug

Description of problem:

ActiveObject.__kill() uses the kill() method of a Popen object, which was added in Python 2.6.  os.kill() is available in Python 2.4.

Version-Release number of selected component (if applicable):

0.0.105, HEAD

How reproducible:

Always.

Steps to Reproduce:

1.  Run grinder under python 2.4.
  
Actual results:

        {'error_type': 'exceptions.AttributeError', 'error': "'Popen' object has no attribute 'kill'", 'traceback': ['Traceback (most recent call last):', '  File "/usr/lib/python2.4/site-packages/grinder/ParallelFetch.py", line 321, in run', '    status,msg = self.fetcher.fetchItem(itemInfo)', '  File "/usr/lib/python2.4/site-packages/grinder/activeobject.py", line 63, in __call__', '    return self.object(self, *args, **kwargs)', '  File "/usr/lib/python2.4/site-packages/grinder/activeobject.py", line 166, in __call__', '    self.__kill()', '  File "/usr/lib/python2.4/site-packages/grinder/activeobject.py", line 145, in __kill', '    self.__child.kill()', "AttributeError: 'Popen' object has no attribute 'kill'"]}

Expected results:

Child respawns.

Additional info:

Patch attached.

Comment 1 Jeff Ortel 2011-07-18 14:53:35 UTC
Fixed in grinder 0.107.