Bug 720806 - Popen.kill is python >= 2.6
Summary: Popen.kill is python >= 2.6
Keywords:
Status: CLOSED EOL
Alias: None
Product: Grinder
Classification: Retired
Component: core
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jeff Ortel
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-12 19:52 UTC by Chris St. Pierre
Modified: 2020-03-27 18:02 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)
patch to fix the bug (742 bytes, application/octet-stream)
2011-07-12 19:52 UTC, Chris St. Pierre
no flags Details

Description Chris St. Pierre 2011-07-12 19:52:25 UTC
Created attachment 512508 [details]
patch to fix the bug

Description of problem:

ActiveObject.__kill() uses the kill() method of a Popen object, which was added in Python 2.6.  os.kill() is available in Python 2.4.

Version-Release number of selected component (if applicable):

0.0.105, HEAD

How reproducible:

Always.

Steps to Reproduce:

1.  Run grinder under python 2.4.
  
Actual results:

        {'error_type': 'exceptions.AttributeError', 'error': "'Popen' object has no attribute 'kill'", 'traceback': ['Traceback (most recent call last):', '  File "/usr/lib/python2.4/site-packages/grinder/ParallelFetch.py", line 321, in run', '    status,msg = self.fetcher.fetchItem(itemInfo)', '  File "/usr/lib/python2.4/site-packages/grinder/activeobject.py", line 63, in __call__', '    return self.object(self, *args, **kwargs)', '  File "/usr/lib/python2.4/site-packages/grinder/activeobject.py", line 166, in __call__', '    self.__kill()', '  File "/usr/lib/python2.4/site-packages/grinder/activeobject.py", line 145, in __kill', '    self.__child.kill()', "AttributeError: 'Popen' object has no attribute 'kill'"]}

Expected results:

Child respawns.

Additional info:

Patch attached.

Comment 1 Jeff Ortel 2011-07-18 14:53:35 UTC
Fixed in grinder 0.107.


Note You need to log in before you can comment on or make changes to this bug.