Bug 720807

Summary:	Review Request: askbot-plugin-authfas - Askbot plugin to facilitate FAS authentication
Product:	[Fedora] Fedora	Reporter:	pjp <pj.pandit>
Component:	Package Review	Assignee:	Rahul Sundaram <metherid>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	metherid, notting, package-review
Target Milestone:	---	Flags:	metherid: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-07-29 09:14:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description pjp 2011-07-12 19:56:51 UTC

Spec URL: http://pjp.dgplug.org/tools/fas-plugin-askbot.spec
SRPM URL: http://pjp.dgplug.org/tools/fas-plugin-askbot-0.1-1.fc14.src.rpm

Description:
Askbot plugin to facilitate FAS authentication. It uses python-fedora
package to send the authentication requests.

It exports a single API which is used by the Askbot server to perform
authentication. It returns True or False based on the authentication result.

 - Boolean check_password(username, password)

Thank you.

Comment 1 Rahul Sundaram 2011-07-12 21:24:20 UTC

The following is redundant and should be removed

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

%clean
rm -rf $RPM_BUILD_ROOT

----

Must add Requires: askbot

Wouldn't BuildRequires include python-devel and python-setup-tools?

Don't add a catch all like the following.  Be a bit more specific. 

%{_datadir}/*
%{python_sitelib}/*

%doc must include license

changelog,  RPM is spelled wrong

Comment 2 Rahul Sundaram 2011-07-12 22:31:16 UTC

I asked in #fedora-admin and recommendation is renaming to

askbot-plugin-authfas

Comment 3 pjp 2011-07-15 20:59:46 UTC

I've made the changes, please see the files below

SPEC: http://pjp.dgplug.org/tools/askbot-plugin-authfas.spec
SRPM: http://pjp.dgplug.org/tools/askbot-plugin-authfas-0.1-2.fc14.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3202564

Thank you.

Comment 4 Rahul Sundaram 2011-07-16 01:43:35 UTC

Request for EPEL 6 branch but don't build anything till we get askbot in the repo 

===  APPROVED ===

Comment 5 Rahul Sundaram 2011-07-16 01:49:05 UTC

Additional note.  Since you are the upstream,  you might want to just rename the tarball and fix the spec file instead of using the srcname macro there

Comment 6 pjp 2011-07-16 09:06:59 UTC

New Package SCM Request
=======================
Package Name: askbot-plugin-authfas
Short Description: Askbot plugin to facilitate FAS authentication.
Owners: pjp sundaram
Branches: f15 el-6

Comment 7 Gwyn Ciesla 2011-07-16 14:38:25 UTC

Git done (by process-git-requests).