Bug 720807 - Review Request: askbot-plugin-authfas - Askbot plugin to facilitate FAS authentication
Summary: Review Request: askbot-plugin-authfas - Askbot plugin to facilitate FAS authe...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Rahul Sundaram
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2011-07-12 19:56 UTC by pjp
Modified: 2011-07-29 09:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-07-29 09:14:12 UTC
Type: ---
metherid: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description pjp 2011-07-12 19:56:51 UTC
Spec URL: http://pjp.dgplug.org/tools/fas-plugin-askbot.spec
SRPM URL: http://pjp.dgplug.org/tools/fas-plugin-askbot-0.1-1.fc14.src.rpm

Askbot plugin to facilitate FAS authentication. It uses python-fedora
package to send the authentication requests.

It exports a single API which is used by the Askbot server to perform
authentication. It returns True or False based on the authentication result.

 - Boolean check_password(username, password)

Thank you.

Comment 1 Rahul Sundaram 2011-07-12 21:24:20 UTC
The following is redundant and should be removed

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)



Must add Requires: askbot

Wouldn't BuildRequires include python-devel and python-setup-tools?

Don't add a catch all like the following.  Be a bit more specific. 


%doc must include license

changelog,  RPM is spelled wrong

Comment 2 Rahul Sundaram 2011-07-12 22:31:16 UTC
I asked in #fedora-admin and recommendation is renaming to


Comment 4 Rahul Sundaram 2011-07-16 01:43:35 UTC
Request for EPEL 6 branch but don't build anything till we get askbot in the repo 

===  APPROVED ===

Comment 5 Rahul Sundaram 2011-07-16 01:49:05 UTC
Additional note.  Since you are the upstream,  you might want to just rename the tarball and fix the spec file instead of using the srcname macro there

Comment 6 pjp 2011-07-16 09:06:59 UTC
New Package SCM Request
Package Name: askbot-plugin-authfas
Short Description: Askbot plugin to facilitate FAS authentication.
Owners: pjp sundaram
Branches: f15 el-6

Comment 7 Gwyn Ciesla 2011-07-16 14:38:25 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.