Bug 724936
| Summary: | Review Request: python-mock - A Python Mocking and Patching Library for Testing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Praveen Kumar <kumarpraveen.nitdgp> |
| Component: | Package Review | Assignee: | Praveen Kumar <kumarpraveen.nitdgp> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, giallu, kumarpraveen.nitdgp, notting, package-review, rtnpro, satya.komaragiri, zooko |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | satya.komaragiri:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-mock-1.0.1-5.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-19 16:05:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 725131 | ||
| Bug Blocks: | 601725 | ||
|
Description
Praveen Kumar
2011-07-22 11:07:04 UTC
[X] Package name - ok. [X] package group - ok. [X] Build successful - ok. [X] rpmlint output: -ok. SRPM: $ rpmlint python-mock-0.7.2-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. SPEC: $ rpmlint python-mock.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. RPM: $ rpmlint python-mock-0.7.2-1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [X] Install/Un-install - ok. [X] Package license - They license name mentioned is 'BSD'. The link provided with the source is to 'The Voidspace Open Source License' (which is a BSD variant but please confirm with Fedora legal as mentioned by mether on IRC). In any case it would still be nice to have a copy of the license with the source. Added license file, I think it's doesn't need to bump up release . Spec URL: http://kumarpraveen.fedorapeople.org/mock/python-mock.spec SRPM URL: http://kumarpraveen.fedorapeople.org/mock/python-mock-0.7.2-1.fc15.src.rpm koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3225612 [X] Package name - ok. [X] Package license - ok [X] package group - ok. [X] Build successful - ok. [X] Install/Un-install - ok. [X] rpmlint output: -ok. SRPM: $ rpmlint python-mock-0.7.2-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. SPEC: $ rpmlint python-mock.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. RPM: $ rpmlint python-mock-0.7.2-1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Overall - Good APPROVED Did anyone try to install this _and_ mock in the same machine? I think we're still clashing (i.e. you will get a conflict on installation), until we fix bug 601725 I've been talking with Zooko of Tahoe-LAFS and Ruben (who is also interested in Tahoe-LAFS) to figure out a way to deal with this until the mock package is updated. Since python-mock is a library needed for testing packages; we could probably get away with packaging the module as a private library for now. Packages which use python-mock in order to build would then be able to set their PYTHONPATH in order to pick up python-mock rather than mock. I can work on adapting this package to do that if you are willing to continue maintaining it. Clark has updated mock to use the mockbuild module name (see bug 601725 ) so I think it's safe to proceed with this. ping Praveen Kumar The mock package has moved to a new module name so this is free to go in now. Are you still interested? Thanks for information, will take a look into it. New Package SCM Request ======================= Package Name: python-mock Short Description: A Python Mocking and Patching Library for Testing Owners: kumarpraveen Branches: f15 f16 Git done (by process-git-requests). python-mock-0.7.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-mock-0.7.2-1.fc16 python-mock-0.7.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/python-mock-0.7.2-1.fc15 python-mock-0.7.2-1.fc16 has been pushed to the Fedora 16 testing repository. python-mock-0.7.2-1.fc16 has been pushed to the Fedora 16 stable repository. python-mock-0.7.2-1.fc15 has been pushed to the Fedora 15 stable repository. New Package SCM Request ======================= Package Name: python-mock Short Description: A Python Mocking and Patching Library for Testing Owners: kumarpraveen Branches: el6 This already exists, please submit a package change request to create a new branch. Thanks! Package Change Request ====================== Package Name: python-mock New Branches: el6 Owners: kumarpraveen Git done (by process-git-requests). python-mock-0.7.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-mock-0.7.2-1.el6 python-mock-0.8.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-mock-0.8.0-1.fc17 python-mock-0.8.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-mock-0.8.0-1.fc16 python-mock-0.8.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/python-mock-0.8.0-1.fc15 python-mock-0.8.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-mock-0.8.0-1.el6 python-mock-0.8.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. python-mock-0.8.0-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. python-mock-0.8.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-mock-0.8.0-2.fc17 python-mock-0.8.0-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-mock-0.8.0-2.fc16 python-mock-1.0.1-5.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-mock-1.0.1-5.el7 python-mock-1.0.1-5.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. Please update python-mock version in EPEL7. mockchain does not run on CentOS 7:
Traceback
=========
[cloud-user@kushal-cent7 SRPMS]$ mockchain
Traceback (most recent call last):
File "/usr/bin/mockchain", line 25, in <module>
from six.moves import urllib_parse
ImportError: cannot import name urllib_parse
It seems like this has been fixed in https://git.fedorahosted.org/cgit/mock.git/commit/?id=af9cbb833e034f6de621475ae56d26effd088321
Sorry, bad post. (In reply to Ratnadeep Debnath from comment #33) > Sorry, bad post. I am going to clear needinfo request, let me know if you have some other query, |