Bug 725006

Summary:	Review Request: smokeqt - Bindings for Qt libraries
Product:	[Fedora] Fedora	Reporter:	Than Ngo <than>
Component:	Package Review	Assignee:	Jaroslav Reznik <jreznik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jreznik, kevin, notting, package-review
Target Milestone:	---	Flags:	jreznik: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-07-28 09:21:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	656997

Description Than Ngo 2011-07-22 14:56:34 UTC

Spec URL: http://than.fedorapeople.org/rawhide/smokeqt.spec
SRPM URL:
http://than.fedorapeople.org/rawhide/smokeqt-4.6.95-1.fc15.src.rpm
Description: Bindings for Qt libraries

Split packaging for smokeqt.

Comment 1 Jaroslav Reznik 2011-07-27 11:16:16 UTC

(smokeqt-4.7.0 review)

Name: ok
Summary: ok
Group: ok
License: not, there's also COPYING.LIB with LGPLv2 (not plus?) license
Url: not ok, http://techbase.kde.org/Development/Languages/Smoke could be used (for all smoke related packages)
Source: ok (md5sum 504dd92fc50f7ccb9cc21ecf31e92da6)
BRs: ok
Conflicts: ?, does it makes sense to conflict with kdebindings in both main spec and -devel? shouldn't devel conflict with kdebindings-devel (but as main package is always needed...)?
Description: ok
Macros used consistently: ok
ldconfig: ok
Devel subpackage: ok

rpmlint smokeqt-4.7.0-1.fc15.src.rpm
smokeqt.src: W: invalid-url URL: http://developer.kde.org/language-bindings/ HTTP Error 404: Not Found

Comment 2 Than Ngo 2011-07-27 12:31:54 UTC

(In reply to comment #1)
> (smokeqt-4.7.0 review)
> 
> Name: ok
> Summary: ok
> Group: ok
> License: not, there's also COPYING.LIB with LGPLv2 (not plus?) license
fixed, license now includes LGPLv2+

> Url: not ok, http://techbase.kde.org/Development/Languages/Smoke could be used
> (for all smoke related packages)
fixed

> Conflicts: ?, does it makes sense to conflict with kdebindings in both main
> spec and -devel? shouldn't devel conflict with kdebindings-devel (but as main
> package is always needed...)?
fixed

could you please take a look at the new package smokeqt-4.7.0-1.fc15.src.rpm and specfile smokeqt.spec ?

thanks

Comment 3 Jaroslav Reznik 2011-07-27 13:35:46 UTC

Ok, thanks.

APPROVED based on http://than.fedorapeople.org/rawhide/smokeqt.spec

Comment 4 Than Ngo 2011-07-27 13:59:21 UTC

Thanks!

New Package SCM Request
=======================
Package Name: smokeqt
Short Description: Bindings for Qt libraries
Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix
Branches: f15 f16

Comment 5 Gwyn Ciesla 2011-07-27 15:38:28 UTC

Git done (by process-git-requests).

Comment 6 Than Ngo 2011-07-28 09:21:44 UTC

imported and built http://koji.fedoraproject.org/koji/buildinfo?buildID=255970