Bug 725006 - Review Request: smokeqt - Bindings for Qt libraries
Summary: Review Request: smokeqt - Bindings for Qt libraries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-07-22 14:56 UTC by Than Ngo
Modified: 2011-07-28 12:58 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-07-28 09:21:44 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Than Ngo 2011-07-22 14:56:34 UTC
Spec URL: http://than.fedorapeople.org/rawhide/smokeqt.spec
SRPM URL:
http://than.fedorapeople.org/rawhide/smokeqt-4.6.95-1.fc15.src.rpm
Description: Bindings for Qt libraries

Split packaging for smokeqt.

Comment 1 Jaroslav Reznik 2011-07-27 11:16:16 UTC
(smokeqt-4.7.0 review)

Name: ok
Summary: ok
Group: ok
License: not, there's also COPYING.LIB with LGPLv2 (not plus?) license
Url: not ok, http://techbase.kde.org/Development/Languages/Smoke could be used (for all smoke related packages)
Source: ok (md5sum 504dd92fc50f7ccb9cc21ecf31e92da6)
BRs: ok
Conflicts: ?, does it makes sense to conflict with kdebindings in both main spec and -devel? shouldn't devel conflict with kdebindings-devel (but as main package is always needed...)?
Description: ok
Macros used consistently: ok
ldconfig: ok
Devel subpackage: ok

rpmlint smokeqt-4.7.0-1.fc15.src.rpm
smokeqt.src: W: invalid-url URL: http://developer.kde.org/language-bindings/ HTTP Error 404: Not Found

Comment 2 Than Ngo 2011-07-27 12:31:54 UTC
(In reply to comment #1)
> (smokeqt-4.7.0 review)
> 
> Name: ok
> Summary: ok
> Group: ok
> License: not, there's also COPYING.LIB with LGPLv2 (not plus?) license
fixed, license now includes LGPLv2+

> Url: not ok, http://techbase.kde.org/Development/Languages/Smoke could be used
> (for all smoke related packages)
fixed

> Conflicts: ?, does it makes sense to conflict with kdebindings in both main
> spec and -devel? shouldn't devel conflict with kdebindings-devel (but as main
> package is always needed...)?
fixed

could you please take a look at the new package smokeqt-4.7.0-1.fc15.src.rpm and specfile smokeqt.spec ?

thanks

Comment 3 Jaroslav Reznik 2011-07-27 13:35:46 UTC
Ok, thanks.

APPROVED based on http://than.fedorapeople.org/rawhide/smokeqt.spec

Comment 4 Than Ngo 2011-07-27 13:59:21 UTC
Thanks!

New Package SCM Request
=======================
Package Name: smokeqt
Short Description: Bindings for Qt libraries
Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix
Branches: f15 f16

Comment 5 Gwyn Ciesla 2011-07-27 15:38:28 UTC
Git done (by process-git-requests).

Comment 6 Than Ngo 2011-07-28 09:21:44 UTC
imported and built http://koji.fedoraproject.org/koji/buildinfo?buildID=255970


Note You need to log in before you can comment on or make changes to this bug.