Bug 725273
Summary: | Alert Definition UI does not display in recent builds of master. | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Simeon Pinder <spinder> |
Component: | Alerts | Assignee: | Simeon Pinder <spinder> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
Severity: | urgent | Docs Contact: | |
Priority: | urgent | ||
Version: | unspecified | CC: | hrupp |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | Type: | --- | |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 678340, 725459 |
Description
Simeon Pinder
2011-07-24 22:51:09 UTC
Some more info: - Most recent pull for master was over the weekend. - Portal.war ui for alert definition still works as a temporary work around. - Making this issue urgent as is a regression in coregui. (9:43:08 AM) mazz: re: the alerts UI (9:43:16 AM) mazz: that should be fixed. we merged into maseter last week (9:43:22 AM) mazz: and I tried creating alet defs and it worked for me (9:43:25 AM) mazz: is that still broken in masteR? segfault sgilda shaines shaun spinder stefan_n sweaver (9:43:58 AM) ccrouch: spinder: ^ ? (9:46:05 AM) mazz: see my 10:40-ish posts in #rhq last Friday on this (9:46:08 AM) mazz: (10:41:56 AM) mazz: BTW: the fact that jsanda merged the drift branch into master means (I think) those problems people had with adding alerts is fixed (9:46:08 AM) mazz: (10:42:06 AM) mazz: I suspect it had to do with changes that I fixed in the Table class. (9:46:08 AM) mazz: (10:42:30 AM) mazz: side note: we need to make a rule - ANY one changing the GWT Table or TableSection needs to get it peer reviewed before commit :) (9:50:29 AM) spinder: mazz: I was hoping so but I pulled on Sunday, did a full build with clean and I staill saw the problem. (9:51:05 AM) spinder: can anyone else who has built with master recently confirm fix or bug? (9:51:17 AM) mazz: ok, so here's what I see (9:51:18 AM) mazz: Unknown.com_smartgwt_client_data_ResultSet_$lengthIsKnown__Lcom_smartgwt_client_data_ResultSet_2Ljava_lang_Boolean_2(Unknown source:0) at Unknown.org_rhq_enterprise_gui_coregui_client_components_table_Table_$refreshRowCount__Lorg_rhq_enterprise_gui_coregui_client_components_table_Table_2V(Unknown source:0) (9:51:29 AM) mazz: this is the change that ips put in that I was talking about in Table (9:51:32 AM) mazz: I thought I fixed this (9:51:40 AM) mazz: please make sure you REALLY did a full clean rebuild (9:51:57 AM) mazz: and this is why we need to have things tested and peer reviewed if things change in Table or TableSection. (9:52:17 AM) mazz: because ANY kind of odd problem will affect many many UI views (all those that have table views in them) (9:52:27 AM) spinder: mazz: agreed. I'm currently walking through alert code. I'll rebuild in a bit... but that takes like 30 mins. (9:53:16 AM) spinder: mazz: +1 to peer reviews of Tables, View etc for coregui. We reuse those parent classes quite often everywhere. Pushing to ON_QA to see if they can quickly check this. Obviously if its still bust, please set on ON_DEV and assign to mazz verified RHQ 4.1 master build 7/25 build, as follows: 1) alert definition ... seems fine, no UI errors 2) additionally verified alerts firing correctly by defining an alert on the RHQ agent on availability change, and stopping/starting the RHQ agent. observed 2 alerts fired. Specifically defining the alert definitions I used during the verification: 1) RHQ Agent, availability change, 2 conditions ... goes down, comes up. I restarted the agent and saw the agent fire 2 times. 2) Platform, Metric value threshold total memory > 0 total swap > 0 In looking back through the mvn build for my test run I did not include 'clean' as I had initially thought. changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE marking VERIFIED BZs to CLOSED/CURRENTRELEASE |