| Summary: | Review Request: gcc-python-plugin - GCC plugin that embeds Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Malcolm <dmalcolm> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jakub, notting, package-review, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-26 16:10:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Dave Malcolm
2011-07-25 21:10:43 UTC
This relates to this Fedora 16 feature: http://fedoraproject.org/wiki/Features/GccPythonPlugin There are some minor items which are not necessary unless you're building for EPEL, specifically: * BuildRoot * rm -rf $RPM_BUILD_ROOT at the beginning of %install * %clean section that simply does rm -rf $RPM_BUILD_ROOT * %defattr(-,root,root,-) lines in %files sections All of these are the implicit defaults now (except in EL-4 and EL-5). Consider removing them before import if you do not plan on supporting those targets. == Review == Good: - rpmlint checks return clean - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream bfc888fc457b3f1b5a6442393eb157a22080059a2f90dff0564a62f1fdd43868 - package compiles on devel (koji) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - docs subpackage okay - nothing in %doc affects runtime - no need for .desktop file APPROVED. New Package SCM Request ======================= Package Name: gcc-python-plugin Short Description: Plugins for embedding various versions of Python within GCC Owners: dmalcolm Branches: InitialCC: Git done (by process-git-requests). Spot, you didn't take ownership of the BZ. <wristslap> (In reply to comment #4) > Git done (by process-git-requests). Thanks! > Spot, you didn't take ownership of the BZ. <wristslap Setting ownership of this bug to Spot. Thanks for the review. Imported as: http://pkgs.fedoraproject.org/gitweb/?p=gcc-python-plugin.git;a=commitdiff;h=0c8191f4f62f3736da8b1f8e27aabec1a6354968 and I've successfully built gcc-python-plugin-0.3-1.fc16 into rawhide (F16 still, it seems) as: http://koji.fedoraproject.org/koji/taskinfo?taskID=3231737 Closing NEXTRELEASE. |