Hide Forgot
Spec URL: http://fedorapeople.org/~dmalcolm/python-packaging/gcc-python-plugin.spec SRPM URL: http://fedorapeople.org/~dmalcolm/python-packaging/gcc-python-plugin-0.3-1.fc15.src.rpm Description: Plugins for embedding various versions of Python within GCC (it's actually built against all 4 versions of python we ship in Fedora, giving 4 gcc plugins, as 4 sub-packages) rpmlint output on local build is clean: $ rpmlint ~/rpmbuild/RPMS/x86_64/*-0.3-1* gcc-python-plugin.spec 6 packages and 1 specfiles checked; 0 errors, 0 warnings. Successful scratch build into dist-f16 here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3228670
This relates to this Fedora 16 feature: http://fedoraproject.org/wiki/Features/GccPythonPlugin
There are some minor items which are not necessary unless you're building for EPEL, specifically: * BuildRoot * rm -rf $RPM_BUILD_ROOT at the beginning of %install * %clean section that simply does rm -rf $RPM_BUILD_ROOT * %defattr(-,root,root,-) lines in %files sections All of these are the implicit defaults now (except in EL-4 and EL-5). Consider removing them before import if you do not plan on supporting those targets. == Review == Good: - rpmlint checks return clean - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream bfc888fc457b3f1b5a6442393eb157a22080059a2f90dff0564a62f1fdd43868 - package compiles on devel (koji) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - docs subpackage okay - nothing in %doc affects runtime - no need for .desktop file APPROVED.
New Package SCM Request ======================= Package Name: gcc-python-plugin Short Description: Plugins for embedding various versions of Python within GCC Owners: dmalcolm Branches: InitialCC:
Git done (by process-git-requests). Spot, you didn't take ownership of the BZ. <wristslap>
(In reply to comment #4) > Git done (by process-git-requests). Thanks! > Spot, you didn't take ownership of the BZ. <wristslap Setting ownership of this bug to Spot. Thanks for the review. Imported as: http://pkgs.fedoraproject.org/gitweb/?p=gcc-python-plugin.git;a=commitdiff;h=0c8191f4f62f3736da8b1f8e27aabec1a6354968 and I've successfully built gcc-python-plugin-0.3-1.fc16 into rawhide (F16 still, it seems) as: http://koji.fedoraproject.org/koji/taskinfo?taskID=3231737 Closing NEXTRELEASE.